Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uuid for unit repeat ids for HFE protocol #650

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 20, 2023

Fixes #640

This is to match RFE protocol

Developers certificate of origin

@IAlibay
Copy link
Member Author

IAlibay commented Nov 20, 2023

This probably fixes #640

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d011065) 90.97% compared to head (c0746c5) 90.97%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         127      127           
  Lines        8679     8679           
=======================================
  Hits         7896     7896           
  Misses        783      783           
Flag Coverage Δ
fast-tests 90.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardjgowers richardjgowers merged commit 34f0bc6 into main Nov 22, 2023
9 checks passed
@richardjgowers richardjgowers deleted the uuid_repeats branch November 22, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AFE protocol doesn't work when gathering multiple ProtocolDAGResults
3 participants