Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix barostat frequency passing #669

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Fix barostat frequency passing #669

merged 7 commits into from
Jan 19, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 24, 2023

FIxes #651

This will affect both the MD protocol and FEFlow.

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented Dec 24, 2023

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 633:80: E501 line too long (87 > 79 characters)
Line 932:80: E501 line too long (84 > 79 characters)
Line 940:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-01-19 11:47:33 UTC

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (181afab) 93.10% compared to head (a1afb45) 91.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   93.10%   91.47%   -1.63%     
==========================================
  Files         132      132              
  Lines        9109     9143      +34     
==========================================
- Hits         8481     8364     -117     
- Misses        628      779     +151     
Flag Coverage Δ
fast-tests 91.47% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardjgowers richardjgowers merged commit 4a8cdc1 into main Jan 19, 2024
8 of 9 checks passed
@richardjgowers richardjgowers deleted the barostat_frequency branch January 19, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barostat frequency settings don't propagate to generated system
3 participants