Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cache to expire after a day #676

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Set cache to expire after a day #676

merged 1 commit into from
Jan 3, 2024

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Jan 2, 2024

Developers certificate of origin

Include the current date in cache key so we get a fresh cache every day

@mikemhenry mikemhenry marked this pull request as ready for review January 2, 2024 22:38
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a2c339) 93.08% compared to head (26a6ced) 91.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   93.08%   91.38%   -1.71%     
==========================================
  Files         132      132              
  Lines        9114     9114              
==========================================
- Hits         8484     8329     -155     
- Misses        630      785     +155     
Flag Coverage Δ
fast-tests 91.38% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member

IAlibay commented Jan 3, 2024

This worked great in the MDA userguide - I'll go ahead with the merge

@IAlibay IAlibay merged commit b1a7c06 into main Jan 3, 2024
8 of 9 checks passed
@IAlibay IAlibay deleted the fix/conda_env_cache branch January 3, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants