Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookbook entry for user charges #687

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 16, 2024

Developers certificate of origin

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (181afab) 93.10% compared to head (f95e75d) 91.37%.
Report is 3 commits behind head on main.

Files Patch % Lines
...tests/protocols/test_openmm_equil_rfe_protocols.py 78.43% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   93.10%   91.37%   -1.74%     
==========================================
  Files         132      132              
  Lines        9109     9158      +49     
==========================================
- Hits         8481     8368     -113     
- Misses        628      790     +162     
Flag Coverage Δ
fast-tests 91.37% <85.13%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It works; the notebook is there in the RTD PR build. I don't know why CodeCov is complaining, but clearly it is about stuff that isn't actually in this diff.

@IAlibay IAlibay merged commit b7224f4 into main Jan 19, 2024
7 of 9 checks passed
@IAlibay IAlibay deleted the add_user_charges_cookbook branch January 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants