Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenizable atom mappers #690

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Tokenizable atom mappers #690

merged 2 commits into from
Jan 25, 2024

Conversation

richardjgowers
Copy link
Contributor

Following this change, OpenFreeEnergy/gufe#266 updates to openfe

Developers certificate of origin

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f95e75d) 91.37% compared to head (443fcf2) 91.36%.
Report is 1 commits behind head on main.

Files Patch % Lines
openfe/tests/setup/atom_mapping/test_atommapper.py 87.50% 1 Missing ⚠️
openfe/tests/setup/test_network_planning.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   91.37%   91.36%   -0.01%     
==========================================
  Files         132      132              
  Lines        9158     9174      +16     
==========================================
+ Hits         8368     8382      +14     
- Misses        790      792       +2     
Flag Coverage Δ
fast-tests 91.36% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's ok not to test the from_dict extra bit?

@richardjgowers
Copy link
Contributor Author

@IAlibay yeah those are toy mappers that aren't ever used in anger

@IAlibay IAlibay merged commit 8e3fecb into main Jan 25, 2024
7 of 9 checks passed
@IAlibay IAlibay deleted the tokenizable_atom_mappers branch January 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants