Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devtools for json results generation + replace old ones #691

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 25, 2024

Fixes #685

Adds a Python script with quickrun-like serialization behaviour so we can re-generate the results files in a consistent manner.

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented Jan 25, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 60:80: E501 line too long (82 > 79 characters)
Line 73:80: E501 line too long (84 > 79 characters)
Line 74:80: E501 line too long (82 > 79 characters)
Line 75:80: E501 line too long (83 > 79 characters)
Line 76:80: E501 line too long (82 > 79 characters)
Line 81:80: E501 line too long (110 > 79 characters)
Line 117:1: W293 blank line contains whitespace

Line 201:80: E501 line too long (94 > 79 characters)

Comment last updated at 2024-01-26 18:09:49 UTC

Copy link
Contributor

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 3 .gz files in devtools/data are the same as the test data files right? So can I remove the 3 devtools/data copies?

@IAlibay
Copy link
Member Author

IAlibay commented Jan 26, 2024

the 3 .gz files in devtools/data are the same as the test data files right? So can I remove the 3 devtools/data copies?

Ah my bad, forgot about those - fixed

@richardjgowers richardjgowers merged commit cfcc924 into main Jan 29, 2024
2 of 7 checks passed
@richardjgowers richardjgowers deleted the devtools-json-generation branch January 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add devtools for creating the test JSON files
3 participants