Skip to content

Modernize enhancedCasting plugin - #4223

Draft
rmarquesbarcelona wants to merge 1 commit into
OpenKore:masterfrom
rmarquesbarcelona:agent/modernize-enhanced-casting
Draft

Modernize enhancedCasting plugin#4223
rmarquesbarcelona wants to merge 1 commit into
OpenKore:masterfrom
rmarquesbarcelona:agent/modernize-enhanced-casting

Conversation

@rmarquesbarcelona

Copy link
Copy Markdown

What changed

  • modernizes the legacy enhancedCasting plugin around current OpenKore hooks and configuration structures
  • selects attack skills and ammunition from monster elemental properties
  • accounts for dynamic property changes and Frozen/Petrified states
  • adds an ecinfo diagnostic command and focused element-table tests

Why

The legacy plugin depends on outdated APIs and hard-coded monster-to-skill decisions. This update uses the current monster database and elemental modifiers so configurations can express available skills and let the plugin choose the effective element.

Impact

Users can enable elemental selection per attack-skill block with target_elementalBest 1, declare each candidate's element, and optionally define tie-breaking priority. Existing configurations remain unchanged unless they opt in.

Root cause

The previous implementation predated current OpenKore hooks and data structures, which made it unsuitable for modern servers and required arbitrary per-monster mappings.

Validation

  • perl plugins/enhancedCasting/t/element_table.t — 12 tests passed
  • git diff --cached --check
  • live plugin reload against the current OpenKore checkout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant