Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for code coverage #72

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Refactor for code coverage #72

merged 1 commit into from
Aug 30, 2023

Conversation

velomatt
Copy link
Contributor

  • don't use cache
  • use expring artifacts
  • add test / archive stages
  • use cov report for both sonar and gitlab

@velomatt
Refactor for code coverage
fcd41ab 
- don't use cache
- use expring artifacts
- add test / archive stages
- use cov report for both sonar and gitlab
@velomatt velomatt requested a review from a team as a code owner August 30, 2023 21:41
@velomatt
Copy link
Contributor Author

velomatt commented Aug 30, 2023 •
edited
Loading

Validated gitlab-ci against mock PR against master on CXL-gitlab: dss/dss-ecosystem/-/merge_requests/11

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

nsarras
nsarras approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@nsarras nsarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@velomatt velomatt merged commit bc263a8 into master Aug 30, 2023
7 checks passed
@velomatt velomatt deleted the refactor-gitlab-ci-for-code-coverage branch August 30, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarras nsarras nsarras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velomatt @nsarras