Nhse d32 nhskv.i17 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid issue when an {error, timeout} may be passed as {error, {error, timeout} - resulting in general 500 error
|
Did a quick experiment taking the JSON library from erlang/otp#8111. There are some issues, as for obvious reasons this is not designed to be compatible with earlier versions. With a naive implementation, and some hacks to resolve compatibility, it was slower in an encode test than thoas/mochijson2 (though probably due to the hacks). I think in this case the performance improvements of |
|
Comparison charts for mochijson2/thoas performance. Absolute: Relative: |
ThomasArts
approved these changes
Feb 19, 2024
|
Having fixed my use of the json encode in the OTP PR, this now appears to be notably faster than thoas - #20 On OTP 22: On OTP 25: |
* Encoding use JSON library for OTP PR Uses the PR'd Json library to OTP for encoding, and passing in a bespoke override on the encode function to avoid the double-pass to convert into a map. This appears to be notably faster than mochijson2 and thoas. * Tidy-up
|
Relative performance at different result sizes - mochijson2 vs OTP Json - OTP 22/24/26: 
|
Focus on proposed JSON library for OTP. The riak_kv_clusteraae_fsm has also been reverted back to mochijson2. The format of leveled_tictac:export_tree isn't compatible with the OTP json library - rather than over-complicate the PR, as performance is not critical for these queries, keep the old implementation.
Without compatibility changes
Compatibility changes required for OTP 22 - 26
ThomasArts
reviewed
Mar 4, 2024
ThomasArts
reviewed
Mar 4, 2024
* Update and include quickcheck properties * Output too verbose with a collect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: