Skip to content

Keep the mobile menu closable when opened after scrolling (develop) #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlaetitia wants to merge 1 commit into
base: develop
Choose a base branch
from
+21 −1
Open

Keep the mobile menu closable when opened after scrolling (develop) #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions themes/osi/assets/scss/_6_components.mobile-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,19 @@
width: 100%;
height: 100%;
overflow: visible;
// the pinned header below leaves the flow: hold its height so the browser
// does not clamp the scroll position when the menu opens near the page end
padding-bottom: $headerInnerHeight;
}

// the scroll lock above drops sticky positioning, which strands the header at
// its static offset: pin it so the logo row and close button stay on screen
.header-main {
position: fixed;
}

.admin-bar .header-main {
top: var(--wp-admin--admin-bar--height);
}

.header--inner {
Expand Down
7 changes: 7 additions & 0 deletions themes/osi/style.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading