Add interactive DisplayList preview - #5
Merged
Conversation
Cloudflare Pages previewLatest PR preview: https://pr-5.display-list-explorer.pages.dev
The PR URL always points to the latest deployment. Each commit snapshot is immutable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The explorer previously showed only the encoded minimal description and metadata, which made it difficult to understand the visual result of a captured DisplayList. The first interaction pass also handled only a single pointer, so browser trackpad and two-touch pinch gestures could not update the preview scale.
User impact
Users can now inspect an approximate visual rendering inside realistic device or window frames, move and scale the canvas directly, enter an exact zoom percentage, and understand which nodes required approximation.
Validation
swift test— 15 tests passed