-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI File Server and Alternate GUI Framework Support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #9 +/- ##
======================================
Coverage ? 53.02%
======================================
Files ? 11
Lines ? 992
Branches ? 0
======================================
Hits ? 526
Misses ? 466
Partials ? 0 |
goldyfruit
reviewed
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README should be updated as well for the qml_server
option.
JarbasAl
commented
May 2, 2023
comments enclosure everywhere, clarity nowhere Update GUI page handling to always write gathered pages locally Support configured GUI directory to write files to (i.e. for a mounted docker volume) Start on URI determination with annotated TODO Add handler to request GUI pages on `ready` not bytes bus upload qml bus upload qml better logs better logs feat/qml_server setting to translate qml paths to urls Increment Version
JarbasAl
force-pushed
the
feat/qml_server
branch
from
June 28, 2023 22:02
51bde6a
to
c0a5b08
Compare
NeonDaniel
requested changes
Jun 29, 2023
JarbasAl
commented
Jul 4, 2023
Update GUI page upload to handle encoded bytes for non-text file support
Remove internal reference to uploaded files
…ccount for different clients Update GuiPage and references to account for resolving resources per-client
JarbasAl
commented
Jul 6, 2023
Include homescreen reload after resource file upload Add unit test coverage
NeonDaniel
approved these changes
Jul 6, 2023
NeonDaniel
changed the title
feat/qml_server
GUI File Server and Alternate GUI Framework Support
Jul 6, 2023
Support upload and resolution of system resources with unit tests
NeonDaniel
approved these changes
Jul 7, 2023
Replaces #18 |
NeonDaniel
approved these changes
Jul 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple GUIs, including multiple concurrent clients using different GUI frameworks
setting to translate qml paths to urls
replaces OpenVoiceOS/ovos-core#38
adds support for ovos-docker