Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log module unit test coverage #260

Merged
merged 11 commits into from
Sep 2, 2024
Merged

log module unit test coverage #260

merged 11 commits into from
Sep 2, 2024

Commits on Jul 16, 2024

  1. Add docstrings and type annotations to log module 

    Add test coverage for log rotation
Outline test coverage for added log module functions
Relates to #2 #239 #233 #250 #253
    @NeonDaniel
    NeonDaniel committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    88d3eab View commit details
    Browse the repository at this point in the history

  2. Update logs to resolve order-related failure

    @NeonDaniel
    NeonDaniel committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    879010b View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Add test coverage for get_logs_config 

    Refactor variable in `get_logs_config` for clarity
Refactor `get_logs_config` for more predictable handling of an empty service name
    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bd27593 View commit details
    Browse the repository at this point in the history

  2. Add test coverage for get_log_path

    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f302252 View commit details
    Browse the repository at this point in the history

  3. Add test coverage for get_log_paths 

    Update `get_log_paths` to check all log names with `-` normalized to `_` (appeared to be the original intent)
Add `enclosure` and `admin` service logs used by Neon and legacy Mycroft/OVOS setups
    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9d20e91 View commit details
    Browse the repository at this point in the history

  4. Add test coverage for get_available_logs

    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7b4252a View commit details
    Browse the repository at this point in the history

  5. Add test coverage for _monitor_log_level

    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bbe9fc8 View commit details
    Browse the repository at this point in the history

  6. Add test of get_config call count

    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2c96bdb View commit details
    Browse the repository at this point in the history

  7. Update get_log_paths to reference config directly instead of test s… 

    …ome well-known values

Update unit test for `get_log_paths`
    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    89db894 View commit details
    Browse the repository at this point in the history

  8. Remove unused ALL_SERVICES variable

    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a7672b9 View commit details
    Browse the repository at this point in the history

  9. Remove unused import

    @NeonDaniel
    NeonDaniel committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6be5c61 View commit details
    Browse the repository at this point in the history