Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump Stylus SDK to v0.6.0 and cargo-stylus to v0.5.1 #273

Merged
merged 4 commits into from
Sep 5, 2024
Merged

build: bump Stylus SDK to v0.6.0 and cargo-stylus to v0.5.1 #273

merged 4 commits into from
Sep 5, 2024

Conversation

bidzyyys
Copy link
Collaborator

@bidzyyys bidzyyys commented Sep 2, 2024

Bump:

  • Stylus SDK to v0.6.0
  • cargo-stylus to v0.5.1

@bidzyyys bidzyyys self-assigned this Sep 2, 2024
qalisander
qalisander approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ggonzalez94
ggonzalez94 reviewed Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! I left a couple comments and one question.

Cargo.toml Show resolved Hide resolved
contracts/src/token/erc721/mod.rs Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Show resolved Hide resolved
This was referenced Sep 3, 2024
Closed
Closed
qalisander
qalisander approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Ship it

@bidzyyys bidzyyys merged commit 42c859f into v0.1.0 Sep 5, 2024
17 checks passed
@bidzyyys bidzyyys deleted the build/sdk-v0.6.0 branch September 5, 2024 11:47
@bidzyyys bidzyyys linked an issue Sep 5, 2024 that may be closed by this pull request
Bump Stylus-SDK Version #231
Closed
1 task
@bidzyyys bidzyyys mentioned this pull request Sep 5, 2024
Closed
1 task
ggonzalez94 pushed a commit that referenced this pull request Sep 10, 2024
@bidzyyys @ggonzalez94
build: bump Stylus SDK to v0.6.0 and cargo-stylus to v0.5.1 (#273)
6741de1 
Bump:
- Stylus SDK to `v0.6.0`
- cargo-stylus to `v0.5.1`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qalisander qalisander qalisander approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees

@bidzyyys bidzyyys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Stylus-SDK Version
3 participants
@bidzyyys @ggonzalez94 @qalisander