Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme fix line endings to be LF not CRLF #268

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

taimoorgit
Copy link
Contributor

@taimoorgit taimoorgit commented Feb 27, 2024

relies on #243

I noticed that for some reason, line endings were CLRF and not LF, and so that caused me a lot of trouble when I was trying to figure out why my git diff's were ending up being so massive and why GoLand was making diffs where each line I added ended with ^M.

@davidbloss
Copy link
Contributor

Does this render any differently??

@taimoorgit
Copy link
Contributor Author

Does this render any differently??

Not at all. But when viewing git diff in a file that's CRLF when all of our other files are LF, you can see weird characters at the end of lines that you changed like ^M.

@taimoorgit taimoorgit closed this Feb 28, 2024
@taimoorgit taimoorgit reopened this Feb 28, 2024
Base automatically changed from ta/rly-small-fixes to main March 1, 2024 21:30
@taimoorgit taimoorgit merged commit 0ab69af into main Mar 1, 2024
2 checks passed
@taimoorgit taimoorgit deleted the ta/fix-readme-line-endings branch March 1, 2024 21:37
@taimoorgit taimoorgit added the documentation Improvements or additions to documentation label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants