Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissingPackageResult field in CheckPackageVersionUpdateInput made Nullable #485

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Oct 22, 2024

Resolves #

Bugfix and updated struct tag examples to have actual enum values

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

service_test.go Outdated Show resolved Hide resolved
scalar.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight docstring wording change but this is MUCH better

better NewNullOf description

Co-authored-by: Kyle <kyle@opslevel.com>
@davidbloss davidbloss merged commit 68ee5fb into main Oct 22, 2024
3 checks passed
@davidbloss davidbloss deleted the db/update-nullable-interface branch October 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants