PR feedback

OpsLevel · Oct 22, 2024 · d3bddf2 · d3bddf2
1 parent 28ebde3
commit d3bddf2
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/tests/aliases.tftest.hcl b/tests/aliases.tftest.hcl
@@ -24,7 +24,7 @@ run "resource_create_aliases" {
   variables {
     resource_type       = "domain"
     resource_identifier = run.from_data_module.first_domain.id
-    aliases             = ["one", "two", "three"]
+    aliases             = toset(["one", "two", "three"])
   }
 
   module {
@@ -40,10 +40,10 @@ run "resource_create_aliases" {
   }
 
   assert {
-    condition = opslevel_alias.this.aliases == toset(["one", "two", "three"])
+    condition = opslevel_alias.this.aliases == var.aliases
     error_message = format(
       "expected '%v' but got '%v'",
-      toset(["one", "two", "three"]),
+      var.aliases,
       opslevel_alias.this.aliases,
     )
   }
@@ -53,18 +53,18 @@ run "resource_modify_managed_aliases" {
   variables {
     resource_type       = "domain"
     resource_identifier = run.from_data_module.first_domain.id
-    aliases = ["one", "four", "three"]
+    aliases = toset(["one", "four", "three"])
   }
 
   module {
     source = "./opslevel_modules/modules/aliases"
   }
 
   assert {
-    condition = opslevel_alias.this.aliases == toset(["one", "four", "three"])
+    condition = opslevel_alias.this.aliases == var.aliases
     error_message = format(
       "expected '%v' but got '%v'",
-      toset(["one", "four", "three"]),
+      var.aliases,
       opslevel_alias.this.aliases,
     )
   }
@@ -85,18 +85,18 @@ run "resource_ensure_managed_aliases" {
   variables {
     resource_type       = "domain"
     resource_identifier = run.from_data_module.first_domain.id
-    aliases = ["one", "four", "three"]
+    aliases = toset(["one", "four", "three"])
   }
 
   module {
     source = "./opslevel_modules/modules/aliases"
   }
 
   assert {
-    condition = opslevel_alias.this.aliases == toset(["one", "four", "three"])
+    condition = opslevel_alias.this.aliases == var.aliases
     error_message = format(
       "expected '%v' but got '%v'",
-      toset(["one", "four", "three"]),
+      var.aliases,
       opslevel_alias.this.aliases,
     )
   }