Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regression tests for known buggy optional string fields #393

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Jul 3, 2024

Issues

Changelog

In opslevel_filter, ensure predicate.key_data is not an empty string in the Terraform config.
Convert OptionalStringValue() to StringValueFromResourceAndModelField() for ambiguous Terraform config string fields that can be an empty string or null.

  • List your changes here
  • Make a changie entry

Tophatting

task test-integration

@davidbloss davidbloss changed the title WIP: add regression tests for known buggy optional string fields add regression tests for known buggy optional string fields Jul 5, 2024
@davidbloss davidbloss self-assigned this Jul 5, 2024
@davidbloss davidbloss marked this pull request as ready for review July 5, 2024 20:14
@davidbloss davidbloss merged commit e9cc42e into main Jul 5, 2024
7 checks passed
@davidbloss davidbloss deleted the db/add-empty-string-regression-tests branch July 5, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants