add send_invite field to opslevel_user resource #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rocktavious
reviewed
Sep 30, 2024
opslevel/resource_opslevel_user.go
Outdated
| @@ -88,6 +90,12 @@ func (r *UserResource) Schema(ctx context.Context, req resource.SchemaRequest, r | |||
| stringvalidator.OneOf(opslevel.AllUserRole...), | |||
| }, | |||
| }, | |||
| "send_invite": schema.BoolAttribute{ | |||
| Description: "Send an invite email even if notifications are disabled for the account.", | |||
| Default: booldefault.StaticBool(true), | |||
There was a problem hiding this comment.
same question as before - should this be off by default? If you are doing a mass invite of users via Terraform you likely don't want to send invites? 🤔
There was a problem hiding this comment.
The other option is to not make it optional so the end user has pick
rocktavious
reviewed
Sep 30, 2024
rocktavious
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #463
Problem
Solution
Checklist