Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF state correctly detects service owner changes from UI, test updated #499

Merged
merged 2 commits into from
Oct 9, 2024
Merged

TF state correctly detects service owner changes from UI, test updated #499

merged 2 commits into from
Oct 9, 2024

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Oct 7, 2024 •
edited
Loading

Resolves #495

Update test relies on this opslevel-modules PR to fix testing a service's note field

Problem

Changes to a service's owner made in UI were not being detected by Terraform's state.

Solution

Fix service's read operation to detect changes to service's owner via the UI. Reflected in TF state.

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@davidbloss davidbloss self-assigned this Oct 7, 2024
rocktavious
rocktavious requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 major comments that I think we need to resolve before shipping

@davidbloss davidbloss merged commit e017789 into main Oct 9, 2024
6 checks passed
@davidbloss davidbloss deleted the db/service-owner-bugfix branch October 9, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocktavious rocktavious rocktavious approved these changes

Assignees

@davidbloss davidbloss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbloss @rocktavious