Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing accessibility problems and HTML validation errors in built-in themes (Lombiq Technologies: OCORE-83) #11243

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Fixing accessibility problems and HTML validation errors in built-in themes (Lombiq Technologies: OCORE-83) #11243

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
830d5b6
Fixing errors in The Coming Soon Theme
DemeSzabolcs Feb 21, 2022
152ad15
Fixing errors in The Agency Theme
DemeSzabolcs Feb 21, 2022
f78837a
Adding missing profile type to aria-label in The Agency Theme
DemeSzabolcs Feb 24, 2022
6d5a43e
Blog Theme removing duplicated fas class
DemeSzabolcs Mar 17, 2022
6856cda
Merge remote-tracking branch 'lombiq/main' into issue/OCORE-83
DemeSzabolcs Jan 20, 2024
97c7ec3
Replacing Twitter icons with the new one
DemeSzabolcs Jan 22, 2024
e53a848
Replacing Twitter icon in more places
DemeSzabolcs Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore.Themes/TheAgencyTheme/Assets/dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ <h3 class="section-subheading text-muted">Lorem ipsum dolor sit amet consectetur
<div class="row align-items-center">
<div class="col-lg-4 text-lg-start">Copyright &copy; Your Website 2022</div>
<div class="col-lg-4 my-3 my-lg-0">
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="Twitter"><i class="fab fa-twitter"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="X (Twitter)"><i class="fab fa-x-twitter"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="Facebook"><i class="fab fa-facebook-f"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="LinkedIn"><i class="fab fa-linkedin-in"></i></a>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/OrchardCore.Themes/TheAgencyTheme/Recipes/Snippets/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
</script>
</div>
<div class="col-lg-4 my-3 my-lg-0">
<a class="btn btn-dark btn-social mx-2" href="#!"><i class="fab fa-twitter" aria-hidden="true"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!"><i class="fab fa-facebook-f" aria-hidden="true"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!"><i class="fab fa-linkedin-in" aria-hidden="true"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="X (Twitter)"><i class="fab fa-x-twitter" aria-hidden="true"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="Facebook"><i class="fab fa-facebook-f" aria-hidden="true"></i></a>
<a class="btn btn-dark btn-social mx-2" href="#!" aria-label="LinkedIn"><i class="fab fa-linkedin-in" aria-hidden="true"></i></a>
</div>
<div class="col-lg-4 text-lg-end">
<a class="link-dark text-decoration-none me-3" href="#!">Privacy Policy</a>
Expand Down
8 changes: 4 additions & 4 deletions src/OrchardCore.Themes/TheAgencyTheme/Recipes/Snippets/landingpage.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,17 @@
<h4>{{ member.DisplayText }}</h4>
<p class="text-muted">{{ member.TeamMember.Occupation.Text }}</p>
{% if member.TeamMember.Twitter.Text.size > 0 %}
<a class="btn btn-dark btn-social mx-2" href="https://www.twitter.com/{{ member.TeamMember.Twitter.Text }}">
<a class="btn btn-dark btn-social mx-2" href="https://www.twitter.com/{{ member.TeamMember.Twitter.Text }}" aria-label="{{ member.DisplayText }} Twitter Profile">
<i class="fab fa-twitter"></i>
</a>
{% endif %}
{% if member.TeamMember.Facebook.Text.size > 0 %}
<a class="btn btn-dark btn-social mx-2" href="https://www.facebook.com/{{ member.TeamMember.Facebook.Text }}">
<a class="btn btn-dark btn-social mx-2" href="https://www.facebook.com/{{ member.TeamMember.Facebook.Text }}" aria-label="{{ member.DisplayText }} Facebook Profile">
<i class="fab fa-facebook"></i>
</a>
{% endif %}
{% if member.TeamMember.LinkedIn.Text.size > 0 %}
<a class="btn btn-dark btn-social mx-2" href="https://www.linkedin.com/in/{{ member.TeamMember.LinkedIn.Text }}">
<a class="btn btn-dark btn-social mx-2" href="https://www.linkedin.com/in/{{ member.TeamMember.LinkedIn.Text }}" aria-label="{{ member.DisplayText }} LinkedIn Profile">
<i class="fab fa-linkedin"></i>
</a>
{% endif %}
Expand All @@ -152,7 +152,7 @@
<div class="row align-items-center">
{% for client in Model.ContentItem.Content.Clients.ContentItems %}
<div class="col-md-3 col-sm-6 my-3">
<a href="{{ client.Client.Url.Text }}">
<a href="{{ client.Client.Url.Text }}" aria-label="{{ client.DisplayText }}">
<img class="img-fluid img-brand d-block mx-auto" src="{{ client.Client.Logo.Paths.first | asset_url }}" alt="">
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/OrchardCore.Themes/TheBlogTheme/Views/Content-Category.Summary.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="post-preview">
{% a display_for:Model.ContentItem %}
<h1>
<i class="fas {{ Model.ContentItem.Content.Category.Icon.Text }} fa-xs" aria-hidden="true"></i>
<i class="{{ Model.ContentItem.Content.Category.Icon.Text }} fa-xs" aria-hidden="true"></i>
Piedone marked this conversation as resolved.
Show resolved Hide resolved
<span class="align-middle">{{ Model.ContentItem.DisplayText }}</span>
</h1>
{% enda %}
Expand Down
2 changes: 1 addition & 1 deletion src/OrchardCore.Themes/TheBlogTheme/Views/Content-Category.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<div class="col-md-10 col-lg-8 col-xl-7">
<div class="site-heading">
<h1>
<i class="fas {{ Model.ContentItem.Content.Category.Icon.Text }} fa-xs" aria-hidden="true"></i>
<i class="{{ Model.ContentItem.Content.Category.Icon.Text }} fa-xs" aria-hidden="true"></i>
<span class="align-middle">{{ Model.ContentItem.DisplayText }}</span>
</h1>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/OrchardCore.Themes/TheComingSoonTheme/Assets/dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ <h1 class="fst-italic lh-1 mb-4">Our Website is Coming Soon</h1>
<!-- For more icon options, visit https://fontawesome.com/icons?d=gallery&p=2&s=brands-->
<div class="social-icons">
<div class="d-flex flex-row flex-lg-column justify-content-center align-items-center h-100 mt-3 mt-lg-0">
<a class="btn btn-dark m-3" href="#!"><i class="fab fa-twitter"></i></a>
<a class="btn btn-dark m-3" href="#!"><i class="fab fa-facebook-f"></i></a>
<a class="btn btn-dark m-3" href="#!"><i class="fab fa-instagram"></i></a>
<a class="btn btn-dark m-3" href="#!" aria-label="X (Twitter)"><i class="fab fa-x-twitter"></i></a>
Piedone marked this conversation as resolved.
Show resolved Hide resolved
<a class="btn btn-dark m-3" href="#!" aria-label="Facebook"><i class="fab fa-facebook-f"></i></a>
<a class="btn btn-dark m-3" href="#!" aria-label="Instagram"><i class="fab fa-instagram"></i></a>
</div>
</div>
<!-- Bootstrap core JS-->
Expand Down
2 changes: 1 addition & 1 deletion src/OrchardCore.Themes/TheComingSoonTheme/Recipes/Snippets/Content__ComingSoon.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="social-icons">
<div class="d-flex flex-row flex-lg-column justify-content-center align-items-center h-100 mt-3 mt-lg-0">
{% for socialicon in Model.ContentItem.Content.SocialIcons.ContentItems %}
<a class="btn btn-dark m-3" href="{{ socialicon.SocialIcon.Url.Text }}">
<a class="btn btn-dark m-3" href="{{ socialicon.SocialIcon.Url.Text }}" aria-label="{{ socialicon.DisplayText }}">
<i class="{{ socialicon.SocialIcon.IconClass.Text }}"></i>
</a>
{% endfor %}
Expand Down
2 changes: 1 addition & 1 deletion src/OrchardCore.Themes/TheComingSoonTheme/Recipes/comingsoon.recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@
},
"FormPart": {
"Action": "[js: getUrlPrefix('/workflows/invoke/' + encodeURI(createWorkflowToken(variables('workflowTypeId'), variables('workflowActivityId'))))]",
"Method": "POST"
"Method": "post"
}
}
]
Expand Down