Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New variables #199

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

New variables #199

wants to merge 13 commits into from

Conversation

aslibese
Copy link
Collaborator

@aslibese aslibese commented Oct 8, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Added two new variables tos and sicons to .json

Does this PR introduce a breaking change?

No, test done

Other information:

Copy link

github-actions bot commented Oct 8, 2024

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst and .zenodo.json:

  • The relevant author information has been added to AUTHORS.rst and .zenodo.json.

Please make sure you've read our contributing guide.
We look forward to reviewing your Pull Request shortly ✨

@github-actions github-actions bot added the docs label Oct 8, 2024
AUTHORS.rst Outdated Show resolved Hide resolved
@Zeitsperre
Copy link
Collaborator

@tlogan2000 Once the PR is ready, feel free to use your ultimate admin powers to merge while bypassing the license check. That check will always fail until I find a moment to split the offending modules out.

Copy link
Collaborator

@tlogan2000 tlogan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

Copy link
Collaborator

@tlogan2000 tlogan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will relook at a couple of things this pm in the end. I'm confused about something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants