Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test search_data_catalogs #251

Merged
merged 18 commits into from
Sep 13, 2023
Merged

Test search_data_catalogs #251

merged 18 commits into from
Sep 13, 2023

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Aug 30, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Tests for search_data_catalogs and its underlying functions.
  • Added the possibility to search for simulations that reach a given warming level within tas_csv.
  • Simplified how we created the main catalog, in search_data_catalogs.
  • Fixed a bug when searching for alternative experiments/members for fixed fields.

Does this PR introduce a breaking change?

  • No

Other information:

  • The tests are based on the new catalog files in Packaging fixes #248, so we'll either need to merge that one first, or merge this PR into 248.

@RondeauG RondeauG changed the title Test extract Test search_data_catalogs Aug 30, 2023
aulemahal
aulemahal approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the docs label Sep 8, 2023
@github-actions github-actions bot added the CI Modifications to autiomation utilities label Sep 8, 2023
juliettelavoie
juliettelavoie approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/notebooks/1_catalog.ipynb Outdated Show resolved Hide resolved
Base automatically changed from packaging-fixes to main September 13, 2023 14:30
@github-actions github-actions bot removed the CI Modifications to autiomation utilities label Sep 13, 2023
@RondeauG RondeauG merged commit 2d1a7fd into main Sep 13, 2023
12 checks passed
@RondeauG RondeauG deleted the test_extract branch September 13, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

@juliettelavoie juliettelavoie juliettelavoie approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RondeauG @aulemahal @juliettelavoie