Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook conventions #476

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix notebook conventions #476

merged 2 commits into from
Oct 10, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Oct 8, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Addresses some ruff coding conventions in global_tas_average_obs.ipynb

Does this PR introduce a breaking change?

No.

Other information:

There are some sensitive locations listed in this file. Probably not a great idea.

@Zeitsperre Zeitsperre self-assigned this Oct 8, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aulemahal
aulemahal approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment. Thanks for the clean up!

@Zeitsperre Zeitsperre merged commit ce0d6a6 into pre-commit-ci-update-config Oct 10, 2024
16 checks passed
@Zeitsperre Zeitsperre deleted the fix-nb-conventions branch October 10, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

@RondeauG RondeauG Awaiting requested review from RondeauG

Assignees

@Zeitsperre Zeitsperre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @aulemahal