Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Use Signals #45

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Use Signals #45

merged 7 commits into from
Feb 7, 2024

Conversation

lishaduck
Copy link
Member

Description

Describe your changes in a sentence or two.

This PR replaces all usages of get_parent() with signals.

Closes: #43

Type of Change

  • ♻️ Code refactor

Checklist

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

  • macOS 14

@lishaduck lishaduck added the enhancement New feature or request label Feb 6, 2024
@lishaduck lishaduck self-assigned this Feb 6, 2024
@lishaduck lishaduck changed the base branch from main to heads-up February 6, 2024 19:07
@lishaduck
Copy link
Member Author

Almost finished. I just need to switch how spawning works, then it'll be finished.

@lishaduck lishaduck marked this pull request as ready for review February 6, 2024 23:51
@lishaduck lishaduck requested a review from a team as a code owner February 6, 2024 23:51
@lishaduck lishaduck modified the milestone: State Feb 7, 2024
@lishaduck lishaduck added chore Relates to something miscellaneous and/or tedious and removed enhancement New feature or request labels Feb 7, 2024
@lishaduck
refactor: use signals in damage system
bb430bd 
I really should switch to be dynamic, but it's fine enough for now.
This commit fully updates the:
* wizard firing logic
* handling of both rock hits and anti-math juice poisoning.
@lishaduck
fix: move number balls to be by wizard hand
56acada
@lishaduck
refactor: update z-indices
bbfaa3b
@lishaduck
chore: change the map a bit
f22fded
@lishaduck
refactor: use signals for respawn
c3ff666
@lishaduck lishaduck mentioned this pull request Feb 7, 2024
Closed
@lishaduck lishaduck merged commit a72b8d4 into heads-up Feb 7, 2024
7 checks passed
@lishaduck lishaduck mentioned this pull request Feb 7, 2024
Merged
@lishaduck lishaduck deleted the signals branch February 7, 2024 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MattsAttack MattsAttack MattsAttack approved these changes

Assignees

@lishaduck lishaduck

Labels
chore Relates to something miscellaneous and/or tedious
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Calls to get_parent()
2 participants
@lishaduck @MattsAttack