[Cleanup] Remove un-necessary const qualifiers in function declarations

src/blockassembler.h

@@ -160,7 +160,7 @@ class BlockAssembler
     const bool defaultPrintPriority{false};
 
 public:
-    BlockAssembler(const CChainParams& chainparams, const bool defaultPrintPriority);
+    BlockAssembler(const CChainParams& chainparams, bool defaultPrintPriority);
     /** Construct a new block template with coinbase to scriptPubKeyIn */
     std::unique_ptr<CBlockTemplate> CreateNewBlock(const CScript& scriptPubKeyIn,
                                    CWallet* pwallet = nullptr,

src/budget/budgetmanager.h

@@ -152,7 +152,7 @@ class CBudgetManager : public CValidationInterface
     bool UpdateFinalizedBudget(const CFinalizedBudgetVote& vote, CNode* pfrom, std::string& strError);
     TrxValidationStatus IsTransactionValid(const CTransaction& txNew, const uint256& nBlockHash, int nBlockHeight) const;
     std::string GetRequiredPaymentsString(int nBlockHeight);
-    bool FillBlockPayee(CMutableTransaction& txCoinbase, CMutableTransaction& txCoinstake, const int nHeight, bool fProofOfStake) const;
+    bool FillBlockPayee(CMutableTransaction& txCoinbase, CMutableTransaction& txCoinstake, int nHeight, bool fProofOfStake) const;
 
     // Only initialized masternodes: sign and submit votes on valid finalized budgets
     void VoteOnFinalizedBudgets();

src/budget/budgetutil.h

@@ -21,7 +21,7 @@ class CWallet;
 UniValue mnLocalBudgetVoteInner(bool fLegacyMN, const uint256& budgetHash, bool fFinal,
                                        const CBudgetVote::VoteDirection& nVote);
 
-UniValue mnBudgetVoteInner(CWallet* const pwallet, bool fLegacyMN, const uint256& budgetHash, bool fFinal,
+UniValue mnBudgetVoteInner(CWallet* pwallet, bool fLegacyMN, const uint256& budgetHash, bool fFinal,
                                   const CBudgetVote::VoteDirection& nVote, const Optional<std::string>& mnAliasFilter);
 
 #endif //PIVX_BUDGETUTIL_H

src/chain.h

@@ -229,7 +229,7 @@ class CBlockIndex
     unsigned int GetStakeEntropyBit() const;
     bool SetStakeEntropyBit(unsigned int nEntropyBit);
     bool GeneratedStakeModifier() const { return (nFlags & BLOCK_STAKE_MODIFIER); }
-    void SetStakeModifier(const uint64_t nStakeModifier, bool fGeneratedStakeModifier);
+    void SetStakeModifier(uint64_t nStakeModifier, bool fGeneratedStakeModifier);
     void SetNewStakeModifier();                             // generates and sets new v1 modifier
     void SetStakeModifier(const uint256& nStakeModifier);
     void SetNewStakeModifier(const uint256& prevoutId);     // generates and sets new v2 modifier

src/core_io.h

@@ -18,7 +18,7 @@ class UniValue;
 
 // core_read.cpp
 extern CScript ParseScript(std::string s);
-extern std::string ScriptToAsmStr(const CScript& script, const bool fAttemptSighashDecode = false);
+extern std::string ScriptToAsmStr(const CScript& script, bool fAttemptSighashDecode = false);
 extern bool DecodeHexTx(CMutableTransaction& tx, const std::string& strHexTx);
 extern bool DecodeHexBlk(CBlock&, const std::string& strHexBlk);
 extern uint256 ParseHashUV(const UniValue& v, const std::string& strName);

src/crypter.h

@@ -91,7 +91,7 @@ friend class wallet_crypto::TestCrypter; // for test access to chKey/chIV
     int BytesToKeySHA512AES(const std::vector<unsigned char>& chSalt, const SecureString& strKeyData, int count, unsigned char *key,unsigned char *iv) const;
 
 public:
-    bool SetKeyFromPassphrase(const SecureString& strKeyData, const std::vector<unsigned char>& chSalt, const unsigned int nRounds, const unsigned int nDerivationMethod);
+    bool SetKeyFromPassphrase(const SecureString& strKeyData, const std::vector<unsigned char>& chSalt, unsigned int nRounds, unsigned int nDerivationMethod);
     bool Encrypt(const CKeyingMaterial& vchPlaintext, std::vector<unsigned char>& vchCiphertext) const;
     bool Decrypt(const std::vector<unsigned char>& vchCiphertext, CKeyingMaterial& vchPlaintext) const;
     bool SetKey(const CKeyingMaterial& chNewKey, const std::vector<unsigned char>& chNewIV);

src/destination_io.h

@@ -13,7 +13,7 @@ typedef boost::variant<CTxDestination, libzcash::SaplingPaymentAddress> CWDestin
 
 namespace Standard {
 
-    std::string EncodeDestination(const CWDestination &address, const CChainParams::Base58Type addrType = CChainParams::PUBKEY_ADDRESS);
+    std::string EncodeDestination(const CWDestination &address, CChainParams::Base58Type addrType = CChainParams::PUBKEY_ADDRESS);
 
     CWDestination DecodeDestination(const std::string& strAddress);
     CWDestination DecodeDestination(const std::string& strAddress, bool& isStaking);

src/hash.h

@@ -334,7 +334,7 @@ class CBLAKE2bWriter
 
 unsigned int MurmurHash3(unsigned int nHashSeed, const std::vector<unsigned char>& vDataToHash);
 
-void BIP32Hash(const ChainCode chainCode, unsigned int nChild, unsigned char header, const unsigned char data[32], unsigned char output[64]);
+void BIP32Hash(ChainCode chainCode, unsigned int nChild, unsigned char header, const unsigned char data[32], unsigned char output[64]);
 
 //int HMAC_SHA512_Init(HMAC_SHA512_CTX *pctx, const void *pkey, size_t len);
 //int HMAC_SHA512_Update(HMAC_SHA512_CTX *pctx, const void *pdata, size_t len);

src/kernel.h

@@ -20,7 +20,7 @@ class CStakeKernel {
      * @param[in]   nBits           target difficulty bits of the kernel block
      * @param[in]   nTimeTx         time of the kernel block
      */
-    CStakeKernel(const CBlockIndex* const pindexPrev, CStakeInput* stakeInput, unsigned int nBits, int nTimeTx);
+    CStakeKernel(const CBlockIndex* pindexPrev, CStakeInput* stakeInput, unsigned int nBits, int nTimeTx);
 
     // Return stake kernel hash
     uint256 GetHash() const;

src/key_io.h

@@ -14,7 +14,7 @@
 #include <string>
 
 std::string EncodeDestination(const CTxDestination& dest, bool isStaking);
-std::string EncodeDestination(const CTxDestination& dest, const CChainParams::Base58Type addrType = CChainParams::PUBKEY_ADDRESS);
+std::string EncodeDestination(const CTxDestination& dest, CChainParams::Base58Type addrType = CChainParams::PUBKEY_ADDRESS);
 // DecodeDestinationisStaking flag is set to true when the string arg is from an staking address
 CTxDestination DecodeDestination(const std::string& str, bool& isStaking);
 CTxDestination DecodeDestination(const std::string& str);

src/libzerocoin/Coin.h

@@ -36,7 +36,7 @@ namespace libzerocoin
     bool IsValidSerial(const ZerocoinParams* params, const CBigNum& bnSerial);
     bool IsValidCommitmentToCoinRange(const ZerocoinParams* params, const CBigNum& bnCommitment);
     CBigNum GetAdjustedSerial(const CBigNum& bnSerial);
-    CBigNum ExtractSerialFromPubKey(const CPubKey pubkey);
+    CBigNum ExtractSerialFromPubKey(CPubKey pubkey);
 
 /** A Public coin is the part of a coin that
  * is published to the network and what is handled
@@ -61,7 +61,7 @@ class PublicCoin
      * @param coin the value of the commitment.
      * @param denomination The denomination of the coin.
      */
-    PublicCoin(const ZerocoinParams* p, const CBigNum& coin, const CoinDenomination d);
+    PublicCoin(const ZerocoinParams* p, const CBigNum& coin, CoinDenomination d);
     const CBigNum& getValue() const { return this->value; }
 
     CoinDenomination getDenomination() const { return this->denomination; }

src/libzerocoin/CoinRandomnessSchnorrSignature.h

@@ -27,7 +27,7 @@ class CoinRandomnessSchnorrSignature {
      * @param randomness the coin we are going to use for the signature (sk := randomness, pk := h^sk mod p).
      * @param msghash hash of meta data to create a signature on.
      */
-    CoinRandomnessSchnorrSignature(const ZerocoinParams* zcparams, const CBigNum randomness, const uint256 msghash);
+    CoinRandomnessSchnorrSignature(const ZerocoinParams* zcparams, CBigNum randomness, uint256 msghash);
 
     /** Verifies the Schnorr signature on message msghash with public key pk = Cg^-S mod p
      *
@@ -37,7 +37,7 @@ class CoinRandomnessSchnorrSignature {
      * @param msghash hash of meta data to verify the signature on.
      * @return
      */
-    bool Verify(const ZerocoinParams* zcparams, const CBigNum& S, const CBigNum& C, const uint256 msghash) const;
+    bool Verify(const ZerocoinParams* zcparams, const CBigNum& S, const CBigNum& C, uint256 msghash) const;
 
     SERIALIZE_METHODS(CoinRandomnessSchnorrSignature, obj) { READWRITE(obj.alpha, obj.beta); }
 

src/libzerocoin/bignum.h

@@ -102,7 +102,7 @@ class CBigNum
         * @param e the exponent as an int
         * @return
         */
-    CBigNum pow(const int e) const;
+    CBigNum pow(int e) const;
 
     /**
      * exponentiation this^e
@@ -146,7 +146,7 @@ class CBigNum
     *                          default causes error rate of 2^-80.
     * @return true if prime
     */
-    bool isPrime(const int checks=15) const;
+    bool isPrime(int checks=15) const;
 
     bool isOne() const;
     bool operator!() const;

src/masternode-sync.h

@@ -91,7 +91,7 @@ class CMasternodeSync
     void PushMessage(CNode* pnode, const char* msg, Args&&... args);
 
     // update peer sync state data
-    bool UpdatePeerSyncState(const NodeId& id, const char* msg, const int nextSyncStatus);
+    bool UpdatePeerSyncState(const NodeId& id, const char* msg, int nextSyncStatus);
 
     // Check if an update is needed
     void CheckAndUpdateSyncStatus();

src/messagesigner.h

@@ -75,7 +75,7 @@ class CSignedMessage
 
     // Sign-Verify message
     bool Sign(const CKey& key, const CKeyID& keyID);
-    bool Sign(const std::string strSignKey);
+    bool Sign(std::string strSignKey);
     bool CheckSignature(const CKeyID& keyID) const;
 
     // Pure virtual functions (used in Sign-Verify functions)

src/net.h

@@ -364,7 +364,7 @@ class CConnman
     void ThreadOpenAddedConnections();
     void AddOneShot(const std::string& strDest);
     void ProcessOneShot();
-    void ThreadOpenConnections(const std::vector<std::string> connect);
+    void ThreadOpenConnections(std::vector<std::string> connect);
     void ThreadMessageHandler();
     void AcceptConnection(const ListenSocket& hListenSocket);
     void DisconnectNodes();

src/netaddress.h

@@ -204,7 +204,7 @@ class CNetAddr
     std::vector<unsigned char> GetAddrBytes() const;
     int GetReachabilityFrom(const CNetAddr* paddrPartner = nullptr) const;
 
-    CNetAddr(const struct in6_addr& pipv6Addr, const uint32_t scope = 0);
+    CNetAddr(const struct in6_addr& pipv6Addr, uint32_t scope = 0);
     bool GetIn6Addr(struct in6_addr* pipv6Addr) const;
 
     friend bool operator==(const CNetAddr& a, const CNetAddr& b);

src/qt/coincontroldialog.h

@@ -104,11 +104,11 @@ class CoinControlDialog : public QDialog
                            const Optional<QString>& stakerAddress,
                            const QString& sWalletLabel,
                            const uint256& txhash,
-                           const uint32_t outIndex,
-                           const CAmount nValue,
-                           const int64_t nTime,
-                           const int nDepth,
-                           const bool isChange);
+                           uint32_t outIndex,
+                           CAmount nValue,
+                           int64_t nTime,
+                           int nDepth,
+                           bool isChange);
 
     // calculate sums for selected amount, number of inputs, change, fee, after fee value, and transaction size
     TotalAmounts getTotals() const;

src/qt/pivx/coldstakingmodel.h

@@ -66,7 +66,7 @@ class ColdStakingModel : public QAbstractTableModel
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
     bool whitelist(const QModelIndex& modelIndex);
     bool blacklist(const QModelIndex& index);
-    void removeRowAndEmitDataChanged(const int idx);
+    void removeRowAndEmitDataChanged(int idx);
     void updateCSList();
     CAmount getTotalAmount() const { return cachedAmount; }
 
@@ -86,7 +86,7 @@ public Q_SLOTS:
     QList<CSDelegation> cachedDelegations;
     CAmount cachedAmount;
 
-    bool parseCSDelegation(const CTxOut& out, CSDelegation& ret, const QString& txId, const int utxoIndex);
+    bool parseCSDelegation(const CTxOut& out, CSDelegation& ret, const QString& txId, int utxoIndex);
 };
 
 #endif // COLDSTAKINGMODEL_H

src/qt/pivx/coldstakingwidget.h

@@ -69,7 +69,7 @@ private Q_SLOTS:
     void onCopyOwnerClicked();
     void onAddressCopyClicked();
     void onAddressEditClicked();
-    void onTxArrived(const QString& hash, const bool isCoinStake, const bool isMNReward, const bool isCSAnyType);
+    void onTxArrived(const QString& hash, bool isCoinStake, bool isMNReward, bool isCSAnyType);
     void onContactsClicked(bool ownerAdd);
     void clearAll();
     void onLabelClicked();
@@ -122,7 +122,7 @@ private Q_SLOTS:
     void onContactsClicked();
     void tryRefreshDelegations();
     bool refreshDelegations();
-    void onLabelClicked(QString dialogTitle, const QModelIndex &index, const bool isMyColdStakingAddresses);
+    void onLabelClicked(QString dialogTitle, const QModelIndex &index, bool isMyColdStakingAddresses);
     void updateStakingTotalLabel();
     void sortAddresses();
     void setCoinControlPayAmounts();

src/qt/pivx/dashboardwidget.h

@@ -122,7 +122,7 @@ private Q_SLOTS:
     void onSortTypeChanged(const QString& value);
     void updateDisplayUnit();
     void showList();
-    void onTxArrived(const QString& hash, const bool isCoinStake, const bool isMNReward, const bool isCSAnyType);
+    void onTxArrived(const QString& hash, bool isCoinStake, bool isMNReward, bool isCSAnyType);
 
 #ifdef USE_QTCHARTS
     void windowResizeEvent(QResizeEvent* event);

src/qt/pivx/governancemodel.h

@@ -143,7 +143,7 @@ class GovernanceModel : public QObject
 
 public Q_SLOTS:
     void pollGovernanceChanged();
-    void txLoaded(const QString& hash, const int txType, const int txStatus);
+    void txLoaded(const QString& hash, int txType, int txStatus);
 
 private:
     ClientModel* clientModel{nullptr};

src/qt/pivx/settings/settingsexportcsv.h

@@ -23,7 +23,7 @@ class SettingsExportCSV : public PWidget
     ~SettingsExportCSV();
 
 private Q_SLOTS:
-    void selectFileOutput(const bool isTxExport);
+    void selectFileOutput(bool isTxExport);
     void exportTxes(const QString& filename);
     void exportAddrs(const QString& filename);
 

src/qt/pivx/settings/settingsfaqwidget.h

@@ -36,7 +36,7 @@ public Q_SLOTS:
    void windowResizeEvent(QResizeEvent* event);
    void setSection(Section _section);
 private Q_SLOTS:
-    void onFaqClicked(const QWidget* const widget);
+    void onFaqClicked(const QWidget* widget);
 private:
     Ui::SettingsFaqWidget *ui;
     Section section = INTRO;

src/qt/pivx/topbar.h

@@ -52,7 +52,7 @@ public Q_SLOTS:
     void setNetworkActive(bool active);
     void setStakingStatusActive(bool fActive);
     void updateStakingStatus();
-    void updateHDState(const bool upgraded, const QString& upgradeError);
+    void updateHDState(bool upgraded, const QString& upgradeError);
     void showUpgradeDialog(const QString& message);
 
 Q_SIGNALS:

src/qt/transactionfilterproxy.h

@@ -59,7 +59,7 @@ class TransactionFilterProxy : public QSortFilterProxyModel
     void setHideOrphans(bool fHide);
 
     int rowCount(const QModelIndex& parent = QModelIndex()) const;
-    static bool isOrphan(const int status, const int type);
+    static bool isOrphan(int status, int type);
 
 protected:
     bool filterAcceptsRow(int source_row, const QModelIndex& source_parent) const;

src/qt/transactiontablemodel.h

@@ -85,9 +85,9 @@ class TransactionTableModel : public QAbstractTableModel
 
 Q_SIGNALS:
     // Emitted only during startup when records gets parsed
-    void txLoaded(const QString& hash, const int txType, const int txStatus);
+    void txLoaded(const QString& hash, int txType, int txStatus);
     // Emitted when a transaction that belongs to this wallet gets connected to the chain and/or committed locally.
-    void txArrived(const QString& hash, const bool isCoinStake, const bool isMNReward, const bool isCSAnyType);
+    void txArrived(const QString& hash, bool isCoinStake, bool isMNReward, bool isCSAnyType);
 
 private:
     // Listeners

src/qt/walletmodel.h

@@ -203,10 +203,10 @@ class WalletModel : public QObject
     void setWalletDefaultFee(CAmount fee = DEFAULT_TRANSACTION_FEE);
     bool hasWalletCustomFee();
     bool getWalletCustomFee(CAmount& nFeeRet);
-    void setWalletCustomFee(bool fUseCustomFee, const CAmount nFee = DEFAULT_TRANSACTION_FEE);
+    void setWalletCustomFee(bool fUseCustomFee, CAmount nFee = DEFAULT_TRANSACTION_FEE);
     CAmount getNetMinFee();
 
-    void setWalletStakeSplitThreshold(const CAmount nStakeSplitThreshold);
+    void setWalletStakeSplitThreshold(CAmount nStakeSplitThreshold);
     CAmount getWalletStakeSplitThreshold() const;
     /* Minimum stake split threshold*/
     double getSSTMinimum() const;
@@ -345,7 +345,7 @@ class WalletModel : public QObject
     std::set<COutPoint> listLockedCoins();
 
     void loadReceiveRequests(std::vector<std::string>& vReceiveRequests);
-    bool saveReceiveRequest(const std::string& sAddress, const int64_t nId, const std::string& sRequest);
+    bool saveReceiveRequest(const std::string& sAddress, int64_t nId, const std::string& sRequest);
 
     ClientModel& clientModel() const { return *m_client_model; }
     void setClientModel(ClientModel* client_model);
@@ -433,7 +433,7 @@ class WalletModel : public QObject
     void notifyReceiveAddressChanged();
 
     /** notify stake-split threshold changed */
-    void notifySSTChanged(const double sstVal);
+    void notifySSTChanged(double sstVal);
 
 public Q_SLOTS:
     /* Wallet balances changes */

src/random.h

@@ -94,7 +94,7 @@ void RandAddPeriodic() noexcept;
  *
  * Thread-safe.
  */
-void RandAddEvent(const uint32_t event_info) noexcept;
+void RandAddEvent(uint32_t event_info) noexcept;
 
 /**
  * Fast randomness source. This is seeded once with secure random data, but

src/rest.cpp

@@ -56,7 +56,7 @@ struct CCoin {
     }
 };
 
-extern void TxToJSON(CWallet* const pwallet, const CTransaction& tx, const CBlockIndex* tip, const CBlockIndex* blockindex, UniValue& entry);
+extern void TxToJSON(CWallet* pwallet, const CTransaction& tx, const CBlockIndex* tip, const CBlockIndex* blockindex, UniValue& entry);
 extern UniValue blockToJSON(const CBlock& block, const CBlockIndex* tip, const CBlockIndex* blockindex, bool txDetails = false);
 extern UniValue mempoolInfoToJSON();
 extern UniValue mempoolToJSON(bool fVerbose = false);

src/rpc/blockchain.cpp

@@ -43,7 +43,7 @@ static std::mutex cs_blockchange;
 static std::condition_variable cond_blockchange;
 static CUpdatedBlock latestblock;
 
-extern void TxToJSON(CWallet* const pwallet, const CTransaction& tx, const CBlockIndex* tip, const CBlockIndex* blockindex, UniValue& entry);
+extern void TxToJSON(CWallet* pwallet, const CTransaction& tx, const CBlockIndex* tip, const CBlockIndex* blockindex, UniValue& entry);
 
 UniValue syncwithvalidationinterfacequeue(const JSONRPCRequest& request)
 {

src/rust/include/librustzcash.h

@@ -98,7 +98,7 @@ extern "C" {
         const unsigned char *diversifier,
         const unsigned char *rcm,
         const unsigned char *ar,
-        const uint64_t value,
+        uint64_t value,
         const unsigned char *anchor,
         const unsigned char *witness,
         unsigned char *cv,
@@ -114,7 +114,7 @@ extern "C" {
         const unsigned char *esk,
         const unsigned char *payment_address,
         const unsigned char *rcm,
-        const uint64_t value,
+        uint64_t value,
         unsigned char *cv,
         unsigned char *zkproof
     );
@@ -182,11 +182,11 @@ extern "C" {
     bool librustzcash_sapling_compute_nf(
         const unsigned char *diversifier,
         const unsigned char *pk_d,
-        const uint64_t value,
+        uint64_t value,
         const unsigned char *r,
         const unsigned char *ak,
         const unsigned char *nk,
-        const uint64_t position,
+        uint64_t position,
         unsigned char *result
     );
 
@@ -199,7 +199,7 @@ extern "C" {
     bool librustzcash_sapling_compute_cm(
         const unsigned char *diversifier,
         const unsigned char *pk_d,
-        const uint64_t value,
+        uint64_t value,
         const unsigned char *r,
         unsigned char *result
     );