-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix points_to_spheres
bug in 3D
#932
Fix points_to_spheres
bug in 3D
#932
Conversation
points_to_spheres
bug in 3D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Could you please also add a unit test to test 2D vs. 3D behaviour?
… im is still NOT TESTED !
I added a simple test case for 2D and 3D. I did not add anything for im being a boolean array, since I do not really know what the expected output would be. It feels broken, but I do not know for sure. |
That seems strange, I can't look at it right now, but will do later this week. |
Is this PR still considered or is it outdated now? |
Sorry for the delay. I still didn't get the chance to review it. Will do this week hopefully. |
I'm so sorry how long this is taking. Amin has a new job now, so it's all on me at the moment. I think the PR is pretty much ready, I'll just go in and fix the tests myself asap. |
I see that "maintainers are allowed to edit this pull request" is enabled, but I honestly don't know how. I would have expected to see this as a branch on my remote which I could pull locally to work on, but that is not how it works. Soooo, I'm just going to merge it into dev, then create a new PR to fix the tests. |
Closes #917