Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All distributions to uniform, fixes #961 #962

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

amirDahari1
Copy link
Contributor

Changed the norm_to_uniform function to all_to_uniform function, to fix #961 since not all distributions that are needed for a specific porosity are normal, including the blobs distribution.

@amirDahari1
Copy link
Contributor Author

Added porosity argument to fractal_noise generator to fix #963. I'm not sure if to keep the uniform argument or not, since porosity already needs the transition to uniform, but thought to keep it for the case when the user prefers the uniform distribution without thresholding.

@jgostick
Copy link
Member

jgostick commented Jun 5, 2024

I am going to merge this PR, then sort out the broken examples afterwards. Thank you very much for this!.

@jgostick jgostick merged commit 4672353 into PMEAL:dev Jun 5, 2024
6 of 7 checks passed
@amirDahari1 amirDahari1 deleted the feature-all_to_uniform branch June 5, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blobs porosity is off for porosity different than 0.5
2 participants