Fixes for XML parsing (don't merge without inspection) #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pment-dt10-changes
|
Thanks for taking the time to identify the problems in the issues, and for proposing fixes. Just to make you aware that I have seen your PR and the issues, and I'll get to them in due time! |
Extracted from dt10_development to make it easier to merge back into 1.0.0-alpha to check on parsing progress.
This is related to #235. Main changes are: - Add CommonBase::HaveIdleWork - Modify CommonBase::MPISpinner to check whether there is idle work, and if not back off down to spinning at 10hz. - Override HaveIdlework in various CommonBase derivatives to indicate if they have idle work.
- gals_heat used sin. Patched to approximation. - relaxation_heat used exit. Patched to fake_handler_exit - Skipping all tests involving externals.
- gals_heat used sin. Patched to approximation. - relaxation_heat used exit. Patched to fake_handler_exit - Skipping all tests involving externals.
|
Is this still needed in light of #264? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note : This is not a straight pull request; it's an invitation to cherry pick, rebase, copy whatever.
It can be closed whenever you like.
This branch contains fixes for #220 , #221 , and #222 , and means that all v4 XML parsing
checks in #208 pass.
While it is merged with 1.0.0-alpha (I think b5615c3), it includes
some possible repeated changes/fixes in it's history, so you probably don't want to merge it without
looking more carefully at all the changes.