Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th No.11】为 Paddle 新增 bernoulli_ / log_normal_ / log_normal API #62934

Closed

Conversation

PommesPeter
Copy link
Contributor

PR types

New features

PR changes

APIs

Description

Working on

Copy link

paddle-bot bot commented Mar 21, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 21, 2024
@PommesPeter PommesPeter changed the title 【Hackathon 5th No.10】为 Paddle 新增 bernoulli_ / log_normal_ / log_normal API 【Hackathon 6th No.10】为 Paddle 新增 bernoulli_ / log_normal_ / log_normal API Mar 21, 2024
@luotao1 luotao1 changed the title 【Hackathon 6th No.10】为 Paddle 新增 bernoulli_ / log_normal_ / log_normal API 【Hackathon 6th No.11】为 Paddle 新增 bernoulli_ / log_normal_ / log_normal API Mar 25, 2024
Copy link

paddle-ci-bot bot commented Mar 30, 2024

Sorry to inform you that e11bf89's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你这里的API设计文档呢?先描述一下计划的实现方式

check_variable_and_dtype(x, "x", ["float32", "float64"], "exponential")

uniform_(x, min=0.0, max=1.0)
return x.set_value((x < p).astype(x.dtype))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能用这种这种直接赋值的形式,这样会导致整个反向图无法构建,你可以用多个API/kernel来组合,或者直接新建一个kernel

@luotao1 luotao1 added the API label Apr 24, 2024
@luotao1 luotao1 closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants