[organization action items] updated OrganizationActionItem screen #2160
Conversation
…fix buttons on mobile screen updated OrganizationActionItems screen to fix button and dropdown menus on mobile screens as buttons were off screen during tablet - mobile
|
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the WalkthroughThe changes made to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (2)
- src/screens/OrganizationActionItems/OrganizationActionItems.module.css (3 hunks)
- src/screens/OrganizationActionItems/OrganizationActionItems.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- src/screens/OrganizationActionItems/OrganizationActionItems.tsx
Additional comments not posted (3)
src/screens/OrganizationActionItems/OrganizationActionItems.module.css (3)
14-15: LGTM! Centering buttons improves alignment.The addition of
justify-content: center;andalign-items: center;in the.btnsContainerclass effectively centers the buttons within the container, enhancing the layout.
155-159: LGTM! Mobile layout adjustments enhance usability.The changes within the media query for
.btnsContainerand.btnsBlockare well-suited for mobile screens, ensuring a vertical stack of elements for better usability.
160-162: LGTM! Dropdown toggle space utilization is improved.Setting
flex-grow: 1;for.btnsContainer .btnsBlock .dropdownToggleensures it expands to fill available space, enhancing layout consistency.
|
looks like test src/screens/FundCampaignPledge/FundCampaignPledge.test.tsx is failing, not sure why as I only changed css on OrganizationActionItems Screen so this error did not come from this PR. |
|
@Alfredoeb9 Please fix the failing tests. |
|
@Cioppolo14 looks like last major file changes on these files were from https://github.com/PalisadoesFoundation/talawa-admin/pull/2064/files from user @GlenDsza. Commit: src/screens/FundCampaignPledge/FundCampaignPledge.tsx Also seeing a new PR: #2163 I suggest teaming up with GlenDsza as this was their task. Those changes are my roadblock, my changes on this PR do not affect unit test from errors seeing above in this PR. |
|
@Alfredoeb9 the issue could be resolved by changing the year values of endDate on following line Set the endDate to something in far distant future |
|
@GlenDsza copy that! Since changes are made in your PR, I'll wait until your changes have integrated so there is no conflict when my PR is merged. Thank you for the follow up! @Cioppolo14 We should wait on this PR merge until @GlenDsza is completely merged to avoid any conflict. |
|
@Cioppolo14 seeing #2163 has been merged. Can we update this PR branch with the latest changes. All tests should be good now. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- src/screens/FundCampaignPledge/PledgesMocks.ts (1 hunks)
Additional comments not posted (1)
src/screens/FundCampaignPledge/PledgesMocks.ts (1)
25-25: Verify the impact of theendDatechange on tests.The
endDatehas been extended to2034-08-08. Ensure that this change aligns with the intended testing scenarios and doesn't inadvertently affect test outcomes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2160 +/- ##
========================================
Coverage 97.55% 97.55%
========================================
Files 244 244
Lines 6939 6939
Branches 2000 2000
========================================
Hits 6769 6769
Misses 155 155
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
@Cioppolo14 @palisadoes PR is ready for review and to be merged 👍. |
|
|
Sure will upload video right now |
|
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
|
Closing. Inactivity. |
…fix buttons on mobile screen
updated OrganizationActionItems screen to fix button and dropdown menus on mobile screens as buttons were off screen during tablet - mobile
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #2094
Did you add tests for your changes?
No, not needed only changed css.
Summary
updated OrganizationActionItems screen to fix button and dropdown menus on mobile screens as buttons were off screen during tablet - mobile
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Style