Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LORE] Extensive Modsuit Lore Drop #27119

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

[LORE] Extensive Modsuit Lore Drop #27119

wants to merge 36 commits into from

Conversation

PopeDaveThe3th
Copy link
Contributor

@PopeDaveThe3th PopeDaveThe3th commented Oct 15, 2024 •
edited
Loading

What Does This PR Do

Adds new descriptions and extended descriptions to all player-usable modsuits, except the clown one.

Also renames modsuits with unique nicknames related to their function.

Why It's Good For The Game

Lore is good.

Lore that isn't stolen from TG is even better.

Testing

  • Loaded in
  • Observed many modsuits
  • Lore is updated

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Changed the descriptions and extended descriptions of almost all modsuits. Updated suits were also given unique names relevant to their occupation.
/:cl:

Fordoxia
Fordoxia reviewed Oct 15, 2024
View reviewed changes
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
PopeDaveThe3th and others added 4 commits October 15, 2024 19:18
@PopeDaveThe3th @Fordoxia
Update code/modules/mod/mod_theme.dm
865e953 
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Fordoxia
Update code/modules/mod/mod_theme.dm
7d3ecb9 
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Fordoxia
Update code/modules/mod/mod_theme.dm
0d0b276 
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th
ogre
3a6a14e
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 16, 2024
@Henri215 Henri215 added Tweak This PR tweaks something ingame Lore This PR changes or adds new lore to the game. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating labels Oct 16, 2024
Henri215
Henri215 reviewed Oct 16, 2024
View reviewed changes
code/modules/mod/mod_theme.dm Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Show resolved Hide resolved
PopeDaveThe3th and others added 8 commits October 16, 2024 07:11
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
9f7c681 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
f80dcb2 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
076cdd4 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
2032b4c 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
75cd879 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
7fad414 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
cb74d78 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
a4163ef 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
Git-GoR
Git-GoR suggested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Git-GoR Git-GoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes. Good work on the rest.

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
PopeDaveThe3th and others added 8 commits October 16, 2024 08:10
@PopeDaveThe3th @Git-GoR
Update mod_theme.dm
c061742 
Co-authored-by: Git-GoR <58085266+Git-GoR@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Git-GoR
Update mod_theme.dm
a906441 
Co-authored-by: Git-GoR <58085266+Git-GoR@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Git-GoR
Update mod_theme.dm
9ddf4d0 
Co-authored-by: Git-GoR <58085266+Git-GoR@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
be0d29a 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
db6b42b 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th
yep
579f0ef
@PopeDaveThe3th
Merge branch 'modsuit-lore' of https://github.com/PopeDaveThe3th/Para…
7fcc4e5 
…dise into modsuit-lore
@PopeDaveThe3th
suits
2d103a7
lewcc
lewcc reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a readability review, meaning a lot of nitpicks. Feel free to dismiss changes you don't feel are especially necessary.

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm
fun and engaging for the players- instead, most were sitting out, dead or gibbed, while the lucky few got to \
have all the fun. If this continues to be a pattern for your \"events\" (Admin Abuse) \
there will be an admin complaint. You have been warned."
desc = "A completely game-breaking suit made of compressed admin abuse. Naturally, it's got bullshit stats, doesn't drain any power at all and... for fuck's sake, does it really need a thousand module slots?!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miiight want to run this one by the design team

@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
60176e8 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
PopeDaveThe3th and others added 14 commits October 16, 2024 14:54
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
cb4d2f8 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
3174b60 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
dda62f4 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
518dfae 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
ca6f971 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
af3af46 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
f2fb4f9 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
305aab2 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
6890f28 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
611647f 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
9b2df45 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @lewcc
Update code/modules/mod/mod_theme.dm
b9a250d 
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th
changes
0ec1c8f
@PopeDaveThe3th
taka
4d6f63a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Henri215 Henri215 Henri215 left review comments

@lewcc lewcc lewcc left review comments

@Fordoxia Fordoxia Fordoxia left review comments

@Git-GoR Git-GoR Git-GoR requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Lore This PR changes or adds new lore to the game. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Tweak This PR tweaks something ingame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PopeDaveThe3th @Git-GoR @Henri215 @lewcc @Fordoxia @ParadiseSS13-Bot