fix error when chest options are invalid

Pathoschild · Dec 21, 2022 · 83fe726 · 83fe726
1 parent b8323d3
commit 83fe726
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/ChestsAnywhere/docs/release-notes.md b/ChestsAnywhere/docs/release-notes.md
@@ -1,6 +1,9 @@
 [← back to readme](README.md)
 
 # Release notes
+## Upcoming release
+* Fixed error when another mod sets invalid chest options.
+
 ## 1.22.4
 Released 30 October 2022 for SMAPI 3.14.0 or later.
 

diff --git a/Common/ModDataDictionaryExtensions.cs b/Common/ModDataDictionaryExtensions.cs
@@ -19,9 +19,19 @@ internal static class ModDataDictionaryExtensions
         [return: NotNullIfNotNull("defaultValue")]
         public static T? ReadField<T>(this ModDataDictionary data, string key, Func<string, T> parse, T? defaultValue = default)
         {
-            return data.TryGetValue(key, out string rawValue)
-                ? parse(rawValue)
-                : defaultValue;
+            if (data.TryGetValue(key, out string rawValue))
+            {
+                try
+                {
+                    return parse(rawValue);
+                }
+                catch
+                {
+                    // if the format is invalid, fallback to the default value
+                }
+            }
+
+            return defaultValue;
         }
 
         /// <summary>Read a field from the mod data dictionary.</summary>