Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Lookup Anything] Look up a body of water to see fishing data #1033

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

b3nk3lly
Copy link
Contributor

@b3nk3lly b3nk3lly commented Sep 13, 2024

Added FishingAreaSubject, which displays data about a body of water. It inherits from TileSubject. It makes use of FishSpawnRulesField.cs to display a list of fish and their spawning conditions. Closes #42.

So far, the FishingAreaSubject displays the fish that can spawn on a particular fishable tile. Only the spawn conditions are shown (no spawn percentage chance yet, or any crab pot data).

I added a progression mode option to hide spawn info for fish that the player hasn't caught yet. This also applies to lookups on fish.

There is currently a bug causing some spawn location names to appear as empty strings. I submitted a fix for that here: #1035

Other technical changes:

  • Added CheckboxList class, with inner classes Intro and Checkbox
  • Replaced instances of KeyValuePair<IFormattedText[], bool> with the new Checkbox class
  • CheckboxListField now supports multiple checkbox lists
  • CheckboxListField now supports drawing a sprite in the list intro

Screenshots:

image image

Currently, legendary fish like the Glacierfish are shown only when the player is in range of the fish's spawn point.

image image image

@b3nk3lly
Copy link
Contributor Author

This is not finished yet - I still have some kinks to work out with the mineshaft floors. Any feedback is much appreciated !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lookup Anything] lookup water to see fishing data
1 participant