-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #30
Conversation
@@ -85,7 +83,9 @@ class PCacheImage extends ImageProvider<PCacheImage> { | |||
return SynchronousFuture<PCacheImage>(this); | |||
} | |||
|
|||
// TODO(chrischv): Replace [DecoderCallback] with [ImageDecoderCallback] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR: After merge this PR, create an issue to keep track this TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanleondev All looks good, could you please check the tests and coverage?
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 90.24% 92.62% +2.37%
==========================================
Files 5 5
Lines 123 122 -1
==========================================
+ Hits 111 113 +2
+ Misses 12 9 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Information
Screenshot
Closes #28