Remediate verified compiler review findings - #86
Merged
Conversation
Harden manifest discovery, init safety, lockfile migration, dependency content pinning, and module-aware callable names.\n\nCentralize atomic publishing, checksum framing, module identity, and callable mangling to preserve validation and ABI invariants without compatibility wrappers.\n\nValidation: go test ./...; bundled x_test; go vet ./...
Reject invalid build and run entrypoints with M0006 before backend artifacts or clang. Keep check mode library-friendly and centralize host-only native link policy for build and run.\n\nEntrypoint validator protects executable ABI and pipeline phase invariants. Native target validator centralizes one policy shared by both native commands.
Reject bodies above 16 MiB before allocation or body reads while accepting the exact limit. Represent successful nil responses explicitly as result null and keep error envelopes result-free.
Parse and emit standards-compliant escaped file URIs across Unix, Windows drive, localhost, and UNC forms. Reject malformed request URIs as invalid params and ignore malformed notification URIs before mutation.\n\nCentralize lexer identifier grammar for rename validation, preserve typed JSON-RPC handler errors, and reject invalid or keyword rename targets before compilation.
Make protocolWriter the serialized output owner so response and diagnostic write failures are retained across synchronous and debounced publication paths. The writer boundary is required to protect the first-error and cancellation invariant across concurrent diagnostic publications.
Give each diagnostic emitter a dedicated color logger and route syntax highlighting and summaries through the same format owner. Logger output methods centralize repeated render-and-write behavior across emitter, highlighter, and summary paths.
Make symbols.Scope the concrete owner used by project and compiler phases, remove runtime scope assertions, and delete the obsolete table package without an alias.
Expose pipeline.Run with explicit compiler context and convert receiver helpers to direct functions while preserving phase scheduling and validation behavior.
Drop unused collector type syntax, import source-module context, and runtime target metadata from canonical signatures and all callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
GOCACHE=/tmp/peeper-go-cache CCACHE_DISABLE=1 go test -count=1 ./...GOCACHE=/tmp/peeper-go-cache CCACHE_DISABLE=1 go vet ./...GOCACHE=/tmp/peeper-go-cache CCACHE_DISABLE=1 go test -race -count=1 ./...GOCACHE=/tmp/peeper-go-cache CCACHE_DISABLE=1 bash scripts/build.shPEEPER_BIN="$PWD/build/bin/peeper" GOCACHE=/tmp/peeper-go-cache CCACHE_DISABLE=1 go test -count=1 ./x_testgit diff --checkArchitecture constraints
mainremain ABI exceptions to module-aware manglingCloses #85