Defend against (impossible) null error

PennyDreadfulMTG · Oct 8, 2024 · 19b0419 · 19b0419
1 parent 6bf6710
commit 19b0419
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/gatherling/Models/Database.php b/gatherling/Models/Database.php
@@ -27,7 +27,7 @@ public static function getConnection(): mysqli
                 $CONFIG['db_password']
             );
             if (mysqli_connect_errno()) {
-                throw new Exception(mysqli_connect_error());
+                throw new Exception((string) mysqli_connect_error());
             }
             $db_selected = $instance->select_db($CONFIG['db_database']);
             if (!$db_selected) {

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -165,11 +165,6 @@ parameters:
 			count: 1
 			path: gatherling/Models/Database.php
 
-		-
-			message: "#^Parameter \\#1 \\$message of class Exception constructor expects string, string\\|null given\\.$#"
-			count: 1
-			path: gatherling/Models/Database.php
-
 		-
 			message: "#^Parameter \\#1 \\$query of method mysqli\\:\\:prepare\\(\\) expects string, mixed given\\.$#"
 			count: 2