Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enzyme pass check and add replace_ir_from_file helper #1204

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tzunghanjuang
Copy link
Collaborator

Context:

In the compiler driver, we only check if there is any GradientOpInterface for enzyme. However, it only works for early mlir levels with replace_ir. This PR moves the check to the llvm level and detects any __enzyme_* functions.

The PR also adds an extra helper replace_ir_from_file to read the replacement ir from file.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (5f3d1d3) to head (6dc72e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          77       77           
  Lines       10921    10926    +5     
  Branches      971      971           
=======================================
+ Hits        10695    10700    +5     
  Misses        179      179           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dime10 dime10 requested a review from a team October 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant