Fix extrapolation in ZNE function #1213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to extrapolate against scale factors rather than folding numbers.
dime10
added
bug
cosenal
approved these changes
Oct 17, 2024
| @@ -273,6 +273,10 @@ | |||
|
|
|||
| <h3>Bug fixes</h3> | |||
|
|
|||
| * Fix a bug in the extrapolation part of the `catalyst.mitigate_with_zne` function that would lead | |||
There was a problem hiding this comment.
nit: the sentence reads a bit redundant. A bug in extrapolation code leads to..incorrect extrapolated result"
There was a problem hiding this comment.
Suggested change
| * Fix a bug in the extrapolation part of the `catalyst.mitigate_with_zne` function that would lead | |
| * Fix a bug in `catalyst.mitigate_with_zne` that would lead |
| @@ -164,14 +162,14 @@ class ZNECallable(CatalystCallable): | |||
| def __init__( | |||
| self, | |||
| fn: Callable, | |||
| num_folds: jnp.ndarray, | |||
| scale_factors: Sequence, | |||
There was a problem hiding this comment.
can type them more strictly as [int]
There was a problem hiding this comment.
Suggested change
| scale_factors: Sequence, | |
| scale_factors: Sequence[int], |
| @@ -209,16 +207,18 @@ def __call__(self, *args, **kwargs): | |||
| callable_fn | |||
| ), "expected callable set as param on the first operation in zne target" | |||
|
|
|||
| results = zne_p.bind( | |||
| *args_data, self.num_folds, folding=folding, jaxpr=jaxpr, fn=callable_fn | |||
| fold_numbers = (jnp.asarray(self.scale_factors, dtype=int) - 1) // 2 | |||
There was a problem hiding this comment.
nice that they became element-wise ops 🤙🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extrapolation was done against the folding numbers instead of the scale factors. Since the folding numbers start at 0, extrapolation would always yield a result very close to the first data point.