Add MPO support to `lightning.tensor` #859

multiphaseCFD · 2024-08-19T21:06:18Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

MPO(Matrix Product Operator) is added to lightning.tensor for all gates support. Any 2 more wires gates and 1 more target wire controlled gates can be supported via MPO. Current implementation only accepts the decomposed gate data. For the python users, MPO decomposition is conducted in the python layer with numpy. Further improvement can be done by conducting MPO decomposition with cusolver for large unitary matrices.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

codecov · 2024-08-19T21:13:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (3718dd6) to head (6b0a268).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   96.29%   91.78%   -4.52%     
==========================================
  Files         212       68     -144     
  Lines       29415     5937   -23478     
==========================================
- Hits        28324     5449   -22875     
+ Misses       1091      488     -603

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ots (#839) **Context:** PR PennyLaneAI/pennylane#6046 wraps the legacy device API automatically in various device creation, qnode, and execute functions. As LK and LGPU plugins still rely on the legacy device API, the shots tests and the `generate_samples` logic in `lightning_kokkos.py` and `lightning_gpu.py` should be updated to adhere the new convention. **Related Shortcut Stories:** [sc-65998] --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Shiro-Raven <exclass9.24@gmail.com> Co-authored-by: albi3ro <chrissie.c.l@gmail.com>

Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [ ] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>

AmintorDusko

Hey @multiphaseCFD! Fantastic work, so far!

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPOTNCuda.hpp

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPSTNCuda.hpp

pennylane_lightning/lightning_tensor/_tensornet.py

pennylane_lightning/lightning_tensor/lightning_tensor.py

maliasadi

Great work @multiphaseCFD! 🚀

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPOTNCuda.hpp

pennylane_lightning/lightning_tensor/lightning_tensor.py

pennylane_lightning/lightning_tensor/_tensornet.py

maliasadi

Thanks @multiphaseCFD! Looks good to go as long as we revisit the support for further expansion and optimization in follow-up PRs as planned. Nice work 💯

pennylane_lightning/lightning_tensor/_tensornet.py

maliasadi

🪂

pennylane_lightning/lightning_tensor/_tensornet.py

AmintorDusko

Would you happen to know why codecov is failing around the _tensornet.py file?

multiphaseCFD · 2024-09-18T12:51:39Z

Would you happen to know why codecov is failing around the _tensornet.py file?

I'm wondering which commit you were checking. Please check here the patch coverage of latest commit is 100%.

AmintorDusko

Thank you, for checking the coverage, and the nice work!

LuisAlfredoNu

Nice work @multiphaseCFD !!! Just a few comments but feel free to ignore them if you need.

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPOTNCuda.hpp

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPSTNCuda.hpp

pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp

ringo-but-quantum and others added 29 commits August 21, 2024 13:23

Auto update version from '0.38.0-dev39' to '0.38.0-dev40'

882cc77

Auto update version from '0.38.0-dev39' to '0.38.0-dev40'

bce32f8

fix conflicts

6cfbe52

Merge branch 'add_probs_ltensor' into add_stateprep_ltensor

2c4a0a7

Merge branch 'master' into add_stateprep_ltensor

fa1d08b

Auto update version from '0.38.0-dev40' to '0.38.0-dev41'

6308d6d

fix codefactor complains

2de2f26

apply Vincent's comments

285e1c9

Merge branch 'master' into add_mpo_ltensor

a34454c

Merge branch 'add_stateprep_ltensor' into add_sample_ltensor

1a8dad4

Merge branch 'add_sample_ltensor' into add_mpo_ltensor

ebc9876

tidy up code

e79bbb3

add changelog and tidy up code

0b215c3

update stopping_condition_shots

503b6dc

Merge branch 'master' into add_stateprep_ltensor

ff01e3e

apply Ali's comments

6a92681

Auto update version from '0.38.0-dev41' to '0.38.0-dev42'

0275d68

pre-allocate Ms

4d5b690

Trigger CIs

1be48eb

add essential headers to unit tests

96e65b2

Auto update version from '0.38.0-dev42' to '0.38.0-dev43'

07ef802

Auto update version from '0.38.0-dev42' to '0.38.0-dev43'

be3fd9c

Merge branch 'master' into add_stateprep_ltensor

3c94a01

Auto update version from '0.38.0-dev42' to '0.38.0-dev43'

737ca5b

fix typo

8ce797b

Merge branch 'add_stateprep_ltensor' into add_sample_ltensor

a94692d

fix typo

c19ae82

add more python unit tests for funtions defined in _tensornet

a82ba09

AmintorDusko reviewed Sep 17, 2024

View reviewed changes

maliasadi reviewed Sep 17, 2024

View reviewed changes

multiphaseCFD added 4 commits September 17, 2024 15:50

apply comments on MPOTNCuda class

c18d159

make format

3a2037f

apply comments on MPSTNCuda

160657c

apply python layer comments

cbccf2d

multiphaseCFD requested review from maliasadi, AmintorDusko and Qottmann September 17, 2024 17:45

refactor gate_matrix_decompose to accept max_mpo_bonddims

60412a0

AmintorDusko reviewed Sep 17, 2024

View reviewed changes

pennylane_lightning/lightning_tensor/_tensornet.py Show resolved Hide resolved

maliasadi reviewed Sep 17, 2024

View reviewed changes

multiphaseCFD added 3 commits September 17, 2024 18:41

add more tests for bond dims check

9d23871

apply comments on py

a83e5d7

apply more comments

c8444f6

maliasadi approved these changes Sep 17, 2024

View reviewed changes

multiphaseCFD requested a review from AmintorDusko September 17, 2024 22:47

AmintorDusko reviewed Sep 18, 2024

View reviewed changes

pennylane_lightning/lightning_tensor/_tensornet.py Show resolved Hide resolved

AmintorDusko reviewed Sep 18, 2024

View reviewed changes

multiphaseCFD and others added 2 commits September 18, 2024 08:56

Merge branch 'master' into add_mpo_ltensor

2775a0d

Auto update version from '0.39.0-dev25' to '0.39.0-dev26'

ea6d82d

AmintorDusko approved these changes Sep 18, 2024

View reviewed changes

Qottmann approved these changes Sep 18, 2024

View reviewed changes

LuisAlfredoNu approved these changes Sep 18, 2024

View reviewed changes

apply Alfredo's suggestions

6b0a268

multiphaseCFD merged commit eb709d5 into master Sep 18, 2024
108 of 109 checks passed

multiphaseCFD deleted the add_mpo_ltensor branch September 18, 2024 16:54

Qottmann mentioned this pull request Sep 19, 2024

Update lightning.tensor docs #909

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MPO support to `lightning.tensor` #859

Add MPO support to `lightning.tensor` #859

multiphaseCFD commented Aug 19, 2024 •

edited

Loading

codecov bot commented Aug 19, 2024 •

edited

Loading

AmintorDusko left a comment

maliasadi left a comment

maliasadi left a comment

maliasadi left a comment

AmintorDusko left a comment

multiphaseCFD commented Sep 18, 2024

AmintorDusko left a comment

LuisAlfredoNu left a comment

Add MPO support to lightning.tensor #859

Add MPO support to lightning.tensor #859

Conversation

multiphaseCFD commented Aug 19, 2024 • edited Loading

Before submitting

codecov bot commented Aug 19, 2024 • edited Loading

Codecov Report

AmintorDusko left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Sep 18, 2024

AmintorDusko left a comment

Choose a reason for hiding this comment

LuisAlfredoNu left a comment

Choose a reason for hiding this comment

Add MPO support to `lightning.tensor` #859

Add MPO support to `lightning.tensor` #859

multiphaseCFD commented Aug 19, 2024 •

edited

Loading

codecov bot commented Aug 19, 2024 •

edited

Loading