Fix qml.probs for lightning.tensor #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
===========================================
+ Coverage 40.29% 97.88% +57.59%
===========================================
Files 39 212 +173
Lines 2683 28279 +25596
===========================================
+ Hits 1081 27681 +26600
+ Misses 1602 598 -1004 ☔ View full report in Codecov by Sentry. |
vincentmr
reviewed
Sep 11, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp
Outdated
Show resolved
Hide resolved
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Outdated
Show resolved
Hide resolved
Sure, added it to the PR description. |
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Show resolved
Hide resolved
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Outdated
Show resolved
Hide resolved
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Outdated
Show resolved
Hide resolved
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Outdated
Show resolved
Hide resolved
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Show resolved
Hide resolved
vincentmr
approved these changes
Sep 11, 2024
LuisAlfredoNu
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
LGTM Thank you @multiphaseCFD for fixing a bug! I left a question for future discussion 🚀
...ne_lightning/core/src/simulators/lightning_tensor/tncuda/measurements/MeasurementsTNCuda.hpp
Show resolved
Hide resolved
multiphaseCFD
added a commit
that referenced
this pull request
Sep 11, 2024
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
[SC-73501]
`cutensornet`'s `Accessor` API allows the users to extract single state
amplitudes (elements of the state tensor), slices of state amplitudes
(slices of the state tensor) as well as the full state tensor. Previous
implementation summed up the slices of the state tensor and compute the
probabilities, which was a bug. This PR sums up the prob of each slices
of the state tensor and fixes the bug.
**Description of the Change:**
**Benefits:**
Analytic probs is supported
**Possible Drawbacks:**
The computation cost could be too expensive to afford if the number of
projected wires is large.
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[SC-73501]
cutensornet'sAccessorAPI allows the users to extract single state amplitudes (elements of the state tensor), slices of state amplitudes (slices of the state tensor) as well as the full state tensor. Previous implementation summed up the slices of the state tensor and compute the probabilities, which was a bug. This PR sums up the prob of each slices of the state tensor and fixes the bug.Description of the Change:
Benefits:
Analytic probs is supported
Possible Drawbacks:
The computation cost could be too expensive to afford if the number of projected wires is large.
Related GitHub Issues: