Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controlled 1-qubit gate support to Lightning Kokkos #952

Draft
wants to merge 9 commits into
base: lk-control-base
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@josephleekl josephleekl added the WIP Work-in-progress issue. Not for general fixing. label Oct 18, 2024
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl added ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request and removed WIP Work-in-progress issue. Not for general fixing. labels Oct 18, 2024
@josephleekl josephleekl marked this pull request as ready for review October 18, 2024 23:57
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 93.94572% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (lk-control-base@035bea0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ators/lightning_kokkos/gates/BasicGateFunctors.hpp 90.72% 18 Missing ⚠️
...nylane_lightning/lightning_kokkos/_state_vector.py 0.00% 9 Missing ⚠️
.../simulators/lightning_kokkos/StateVectorKokkos.hpp 86.66% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             lk-control-base     #952   +/-   ##
==================================================
  Coverage                   ?   97.38%           
==================================================
  Files                      ?      215           
  Lines                      ?    30838           
  Branches                   ?        0           
==================================================
  Hits                       ?    30033           
  Misses                     ?      805           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl marked this pull request as draft October 19, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant