-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controlled 1-qubit gate support to Lightning Kokkos #952
Draft
josephleekl
wants to merge
9
commits into
lk-control-base
Choose a base branch
from
lk-control-gate-1Q
base: lk-control-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
josephleekl
force-pushed
the
lk-control-gate-1Q
branch
from
October 18, 2024 19:35
4a15f30
to
6d10fad
Compare
josephleekl
force-pushed
the
lk-control-base
branch
from
October 18, 2024 19:38
d5ae740
to
fd9df9f
Compare
josephleekl
force-pushed
the
lk-control-gate-1Q
branch
from
October 18, 2024 19:41
6d10fad
to
aa830a3
Compare
josephleekl
force-pushed
the
lk-control-gate-1Q
branch
from
October 18, 2024 23:40
aa830a3
to
38c48b9
Compare
josephleekl
added
ci:build_wheels
Activate wheel building.
ci:use-gpu-runner
Enable usage of GPU runner for this Pull Request
and removed
WIP
Work-in-progress issue. Not for general fixing.
labels
Oct 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lk-control-base #952 +/- ##
==================================================
Coverage ? 97.38%
==================================================
Files ? 215
Lines ? 30838
Branches ? 0
==================================================
Hits ? 30033
Misses ? 805
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:build_wheels
Activate wheel building.
ci:use-gpu-runner
Enable usage of GPU runner for this Pull Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: