Making arithmetic templates QJIT compatible #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6307 +/- ##
=======================================
Coverage 99.39% 99.40%
=======================================
Files 446 446
Lines 42328 42364 +36
=======================================
+ Hits 42073 42110 +37
+ Misses 255 254 -1 ☔ View full report in Codecov by Sentry. |
KetpuntoG
reviewed
Oct 2, 2024
The qjit tests live in the Catalyst repo. See this PR for the added tests. |
obliviateandsurrender
approved these changes
Oct 6, 2024
soranjh
reviewed
Oct 7, 2024
soranjh
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following template QJIT compatible.
The issue stems from the use of
qml.adjoint()as an iterable in the PhaseAdder and Multiplier templates. In Catalyst, the correspondingHybridAdjointclass is compatible with PennyLane'sAdjointclass for single operations, but incompatible for multiple operations (see this Catalyst PR). The solution is add eachqml.adjoint(op)to the decomposition list individually, instead of extending the list by treating the adjoint as an iterable.While this PR makes OutAdder and OutMultiplier QJIT compatible, there is another issue with them that prevents them from returning the correct answer when compiled with QJIT. This bug will be addressed in a separate PR.
This PR addresses sc-74445.