chore: updated readme to document join map, removed TODOs, added comp…

…any name to AssemblyInfo
PepperDash · Nov 16, 2022 · bb6e32b · bb6e32b
1 parent 04d37a3
commit bb6e32b
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -31,8 +31,11 @@ This plugin is designed to work with Barco G60 projector controlled via Telnet (
       }
     },
     "pollIntervalMs": 60000,
-    "coolingTimeMs": 15000,
-    "warmingTimeMs": 15000
+    "coolingTimeMs": 30000,
+    "warmingTimeMs": 30000,
+    "hasLamps": true,
+    "hasScreen": true,
+    "hasLift": false
   }
 }
 ```
@@ -60,12 +63,19 @@ This plugin is designed to work with Barco G60 projector controlled via Telnet (
       }
     },
     "pollIntervalMs": 60000,
-    "coolingTimeMs": 15000,
-    "warmingTimeMs": 15000
+    "coolingTimeMs": 30000,
+    "warmingTimeMs": 30000,
+    "hasLamps": true,
+    "hasScreen": true,
+    "hasLift": false
   }
 }
 ```
 
+#### Notes
+
+`hasLamps`, `hasScreen`, `hasLift` are configuration options that are exposed via the Bridge and can be leveraged by the developer in SIMPL.
+
 ### Bridge
 ```json
 {
@@ -110,6 +120,11 @@ The tables below document the digital, analog, and serial joins of PepeprDash Es
 | Input Select 4 - VGA       | 14  | Input 4 Feedback - VGA                         |
 | Input Select 5 - SDI       | 15  | Input 5 Feedback - SDI                         |
 | Input Select 6 - HD Base-T | 16  | Input 6 Feedback - HD Base-T                   |
+|                            | 31  | Has Lamps Configuration Feedback               |
+|                            | 32  | Has Screen Configuration Feedback              |
+|                            | 33  | Has Lift Configuration Feedback                |
+|                            | 36  | Is Warming Feedback                            |
+|                            | 37  | Is Cooling Feedback                            |
 |                            | 41  | Input 1 Button Visibility Feedback - HDMI 1    |
 |                            | 42  | Input 2 Button Visibility Feedback - HDMI 2    |
 |                            | 43  | Input 3 Button Visibility Feedback - DVI       |

diff --git a/epi-barco-g60/BarcoG60Device.cs b/epi-barco-g60/BarcoG60Device.cs
@@ -20,6 +20,7 @@ public class BarcoG60Controller : TwoWayDisplayBase, ICommunicationMonitor,
 		// https://www.barco.com/en/support/g60-w10/docs
 		// https://www.barco.com/services/website/en/TdeFiles/Download?FileNumber=R5910887&TdeType=1&Revision=01&ShowDownloadPage=False
 
+		private bool _isSerialComm;
 		private bool HasLamps { get; set; }
 		private bool HasScreen { get; set; }
 		private bool HasLift { get; set; }
@@ -63,8 +64,8 @@ public BarcoG60Controller(string key, string name, BarcoG60PropertiesConfig conf
 
 			DeviceManager.AddDevice(CommunicationMonitor);
 
-			WarmupTime = props.WarmingTimeMs > 10000 ? props.WarmingTimeMs : 15000;
-			CooldownTime = props.CoolingTimeMs > 10000 ? props.CoolingTimeMs : 15000;
+			WarmupTime = props.WarmingTimeMs > 30000 ? props.WarmingTimeMs : 30000;
+			CooldownTime = props.CoolingTimeMs > 30000 ? props.CoolingTimeMs : 30000;
 
 			HasLamps = props.HasLamps;
 			HasScreen = props.HasScreen;
@@ -576,7 +577,6 @@ public void ListRoutingInputPorts()
 		/// </summary>
 		public void InputHdmi1()
 		{
-			// TODO [ ] verify input selection commands
 			SendText("MSRC", 1);
 		}
 
@@ -585,7 +585,6 @@ public void InputHdmi1()
 		/// </summary>
 		public void InputHdmi2()
 		{
-			// TODO [ ] verify input selection commands
 			SendText("MSRC", 2);
 		}
 
@@ -610,7 +609,6 @@ public void InputHdmi5()
 		/// </summary>
 		public void InputDvi1()
 		{
-			// TODO [ ] verify input selection commands
 			SendText("MSRC", 3);
 		}
 
@@ -619,7 +617,6 @@ public void InputDvi1()
 		/// </summary>
 		public void InputHdBaseT1()
 		{
-			// TODO [ ] verify input selection commands
 			SendText("MSRC", 4);
 		}
 
@@ -628,7 +625,6 @@ public void InputHdBaseT1()
 		/// </summary>
 		public void InputVga1()
 		{
-			// TODO [ ] verify input selection commands
 			SendText("MSRC", 0);
 		}
 
@@ -637,7 +633,6 @@ public void InputVga1()
 		/// </summary>
 		public void InputSdi1()
 		{
-			// TODO [ ] verify input selection commands
 			SendText("MSRC", 5);
 		}
 
@@ -646,9 +641,6 @@ public void InputSdi1()
 		/// </summary>
 		public void InputToggle()
 		{
-			// TODO [ ] Fill in input recall command and values
-			//SendText("", "");
-
 			throw new NotImplementedException();
 		}
 
@@ -657,7 +649,6 @@ public void InputToggle()
 		/// </summary>
 		public void InputGet()
 		{
-			// TODO [ ] verify input poll command
 			SendText("MSRC", "?");
 		}
 
@@ -683,7 +674,7 @@ public void UpdateInputFb(string s)
 
 			var key = newInput.Key;
 			Debug.Console(DebugNotice, this, "UpdateInputFb: key-'{0}'", key);
-			// TODO [ ] Update input values to align with API
+
 			switch (key)
 			{
 				case "hdmiIn1":
@@ -743,7 +734,6 @@ private void UpdateBooleanFeedback(int data)
 		#region Power
 
 		private bool _isCoolingDown;
-		private bool _isSerialComm;
 		private bool _isWarmingUp;
 		private bool _powerIsOn;
 

diff --git a/epi-barco-g60/Properties/AssemblyInfo.cs b/epi-barco-g60/Properties/AssemblyInfo.cs
@@ -1,7 +1,7 @@
 using System.Reflection;
 
 [assembly: AssemblyTitle("PepperDash.Essentials.Plugin.Projector.BarcoG60")]
-[assembly: AssemblyCompany("")]
+[assembly: AssemblyCompany("PepperDash")]
 [assembly: AssemblyProduct("PepperDash.Essentials.Plugin.Projector.BarcoG60")]
 [assembly: AssemblyCopyright("Copyright ©  2022")]
 [assembly: AssemblyVersion("0.0.0.*")]