Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with assistant selector #198

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix issue with assistant selector #198

merged 1 commit into from
Sep 21, 2024

Conversation

s2sa4v
Copy link
Collaborator

@s2sa4v s2sa4v commented Sep 21, 2024

Fixes issue with Assistant Selector where on assistant selection and clicking on Create Assistant the selector would still display an old value when the current assistant is undefined.
Simplifies assistant selector code a bit.
Adds headers to Create and Edit assistant forms.
Adds gray background for forms - this could be deleted - I just played with it.

To test:

Choose assistant
Make sure the assistant is chosen in the Select and reflected in url (a/...)
Click on Create Assistant
Make sure the assistant is reset in Select and URL

when create assistant is chosen and current assistant is reset, the selector would still display assistant.
Copy link
Collaborator

@krishokr krishokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a ton for the bug fix! That puzzled me at one point actually. I may play off of what you did with some styles.

Actually though - I'm missing how you fixed the AssistantSelector! What line of code did the fix?

@krishokr krishokr merged commit 940215f into main Sep 21, 2024
2 checks passed
@krishokr krishokr deleted the stas/ui-changes branch September 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants