Events definition handling #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
This looks good. I'm not entirely certain whether we will want to represent the "indexed" property as a set of indices or as a list of booleans, but I imagine we'll figure that out when we implement the "emit" statement.
Did you test that between this PR and the one for visibility, the uniswap contract can execute to the point of the "payable" modifier?
|
Looks like this PR needs a quick update to the output files. |
|
Yes, it is stuck with the payable deposit function at the top of the k cell. For the indexed property, I will keep that in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1745, event definitions.
There is a new cell that holds the information for an event's name, arg types and names, and set of indexed event parameters. I oped to have this cell maintain the integer positions of the indexed parameters rather than their name, because if there are more than one unnamed parameters then the name would not be enough.