Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary for swapExactTokensForTokens #62

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Summary for swapExactTokensForTokens #62

merged 6 commits into from
Oct 11, 2024

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Oct 11, 2024 •
edited
Loading

This PR adds summarized rules for function swapExactTokensForTokens of contract uniswapV2Router02.

solidity-demo-semantics/test/examples/swaps/UniswapV2SwapRenamed.sol

Line 113 in dd6d2d0

function swapExactTokensForTokens(

These rules reduce the steps by 357 (from 15011 to 14654).

@mariaKt mariaKt marked this pull request as ready for review October 11, 2024 15:03
Robertorosmaninho
Robertorosmaninho reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few clarifications questions before approving it

src/uniswap-summaries.md Show resolved Hide resolved
src/uniswap-summaries.md Show resolved Hide resolved
Robertorosmaninho
Robertorosmaninho approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All questions were replied in the meeting. The code LGTM!

@mariaKt mariaKt merged commit 4233736 into main Oct 11, 2024
1 check passed
@mariaKt mariaKt deleted the swapetft-summary branch October 11, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robertorosmaninho Robertorosmaninho Robertorosmaninho approved these changes

@dwightguth dwightguth Awaiting requested review from dwightguth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariaKt @Robertorosmaninho