Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command group aliases #182

Merged
merged 10 commits into from
Aug 23, 2024
Merged

Add support for command group aliases #182

merged 10 commits into from
Aug 23, 2024

Conversation

fbdtemme
Copy link
Contributor

@fbdtemme fbdtemme commented Aug 22, 2024

Description

This adds support for aliases to command groups using the AliasedOrderedGroup class for click.
Update some internal keys to single-cell-mpx instead of single-cell

Fixes: EXE-1954

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests pass, pipeline passes, qc report is valid.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If a new tool or package is included, I have updated poetry.lock, and cited it properly
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (622cb6f) to head (cab3ad9).
Report is 5 commits behind head on dev.

Files Patch % Lines
src/pixelator/cli/common.py 41.66% 14 Missing ⚠️
src/pixelator/report/common/cli_info.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev     #182       +/-   ##
========================================
+ Coverage     0   81.89%   +81.89%     
========================================
  Files        0      121      +121     
  Lines        0     6905     +6905     
========================================
+ Hits         0     5655     +5655     
- Misses       0     1250     +1250     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbdtemme
Copy link
Contributor Author

There seems to be an issue with the updated version of tox and the use-current-env plugin.
This should be fixed in: #184

@fbdtemme fbdtemme changed the title Rename single-cell to single-cell-mpx and make single-cell an alias Add support for command group aliases Aug 22, 2024
Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ambarrio
Copy link
Contributor

One test crashing. Is the tox thing you found?

Copy link
Contributor

@johandahlberg johandahlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I am a little bit concerned that some of the numeric the test results are changing. Do you have any feel for why that is?

@fbdtemme
Copy link
Contributor Author

fbdtemme commented Aug 23, 2024

I have made a new test data generation run to test the new meta.json files.
These very small numerical changes are common whenever the testdata is rerun.
After the scope change of this ticket it is actually not needed to update the testdata so I'll drop that from the PR.

The test failures should indeed be fixed with the tox PR that is now merged.

@fbdtemme fbdtemme merged commit 6b21513 into dev Aug 23, 2024
14 checks passed
@fbdtemme fbdtemme deleted the feature/exe-1954 branch August 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants