-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for command group aliases #182
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #182 +/- ##
========================================
+ Coverage 0 81.89% +81.89%
========================================
Files 0 121 +121
Lines 0 6905 +6905
========================================
+ Hits 0 5655 +5655
- Misses 0 1250 +1250 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There seems to be an issue with the updated version of tox and the use-current-env plugin. |
single-cell
to single-cell-mpx
and make single-cell
an aliasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
One test crashing. Is the tox thing you found? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I am a little bit concerned that some of the numeric the test results are changing. Do you have any feel for why that is?
I have made a new test data generation run to test the new meta.json files. The test failures should indeed be fixed with the tox PR that is now merged. |
cab3ad9
to
7683f26
Compare
7683f26
to
88657ac
Compare
Description
This adds support for aliases to command groups using the
AliasedOrderedGroup
class for click.Update some internal keys to
single-cell-mpx
instead ofsingle-cell
Fixes: EXE-1954
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing tests pass, pipeline passes, qc report is valid.
PR checklist: