Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webreport template #9

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Update webreport template #9

merged 4 commits into from
Sep 20, 2023

Conversation

fbdtemme
Copy link
Contributor

Description

Update the webreport template to be able to make use of relative constraint checks.

Some small fixes and chores:

  • Skip end-of-file-fixer on webreport/template.html
  • Remove unused conda recipe, the real one lives in bioconda
  • update poetry.lock

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

ambarrio
ambarrio approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbdtemme fbdtemme merged commit f74e1ee into dev Sep 20, 2023
13 checks passed
@fbdtemme fbdtemme deleted the feature/webreport-relative-constraints branch September 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambarrio ambarrio ambarrio approved these changes

@johandahlberg johandahlberg Awaiting requested review from johandahlberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbdtemme @ambarrio