Skip to content

fix(npm): accept successful OIDC exchange status - #8

Merged
ajay-bhargava merged 1 commit into
mainfrom
fix/npm-oidc-success-status
Jul 28, 2026
Merged

fix(npm): accept successful OIDC exchange status#8
ajay-bhargava merged 1 commit into
mainfrom
fix/npm-oidc-success-status

Conversation

@ajay-bhargava

@ajay-bhargava ajay-bhargava commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

  • accept all successful HTTP 2xx responses from npm OIDC token exchange
  • handle npm registry's current 201 Created response

Testing

  • bash -n scripts/preflight-npm-oidc.sh
  • git diff --check

View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33660f19-dedc-42fd-9e35-db17ff66fd51

📥 Commits

Reviewing files that changed from the base of the PR and between b1cb6ce and b392786.

📒 Files selected for processing (1)
  • scripts/preflight-npm-oidc.sh

📝 Walkthrough

Walkthrough

The npm OIDC preflight script now marks a package as ready when its token exchange returns any HTTP 2xx status with a token field, rather than requiring status 200.

Changes

npm OIDC preflight

Layer / File(s) Summary
Generalize OIDC success validation
scripts/preflight-npm-oidc.sh
The success check accepts any 2xx HTTP response that contains a token field, and the accompanying comment reflects this behavior.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@ajay-bhargava
ajay-bhargava merged commit dd851da into main Jul 28, 2026
4 checks passed
@ajay-bhargava
ajay-bhargava deleted the fix/npm-oidc-success-status branch July 28, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant